react-native-fast-image icon indicating copy to clipboard operation
react-native-fast-image copied to clipboard

Allow iOS to clear the tintColor property.

Open sleeper-seth opened this issue 6 years ago • 3 comments

By allowing the image color to be set to nil, it's possible to set and then unset a tint color.

This now matches the Android behavior defined in FastImageViewManager.java

FastImageViewManager

sleeper-seth avatar Oct 16 '19 20:10 sleeper-seth

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.11%. Comparing base (534d70d) to head (a0ae994). Report is 99 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           1        1           
  Lines          17       17           
=======================================
  Hits           16       16           
  Misses          1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 16 '19 20:10 codecov[bot]

This doesn't really works. It removes the tintColor but image still has a black tintColor for some reason.

eminsr avatar Oct 22 '19 14:10 eminsr

There are still issues with thetintColor on iOS devices, the value is not cleared, so if switching on/off, the value stacks up.

Noitham avatar Jan 20 '22 18:01 Noitham