react-native-fast-image
react-native-fast-image copied to clipboard
Fixed graphics context allocation issue
Title: Resolved Graphics Context Allocation Issue
Description:
Proposed Changes This PR resolves an issue pertaining to graphics context allocation in the FFFastImageViewManager. The previous implementation utilized older graphics context handling methods, which could potentially lead to errors. This PR updates the code to leverage the newer UIGraphicsImageRenderer API, mitigating any context allocation problems.
Changes Made
- Updated FFFastImageViewManager.m to utilize UIGraphicsImageRenderer for managing image context.
- Eliminated manual handling of context creation and cleanup, reducing the likelihood of errors.
Graphics Context Handling: It now employs UIGraphicsImageRenderer, a more modern API introduced in iOS 10. This API handles the creation, rendering, and cleanup of the image context automatically.
Renderer Usage: It now creates a UIGraphicsImageRenderer object (renderer) and employs it to execute the drawing operations.
Error Handling: It leverages a more modern API that is less susceptible to context allocation errors.
This PR addresses: #1006
Works well for me on iOS 17
Working fine on iOS 17. Thanks
@DylanVann Please merge
someone please tell me how to install this pull by npm
someone please tell me how to install this pull by npm
You can apply a patch, see https://github.com/DylanVann/react-native-fast-image/issues/1002#issuecomment-1742663000
@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?
@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?
I don't understand exactly what you mean by "I already have a patch applied for fast image in podsec file" - could you be a bit more specific? If you want to understand how to apply a patch for an npm package, the best way is to read the usage instructions for patch-package.
Got it thanx @AdamGerthel
Thank you for this!
@DylanVann please, man, merge this.
@DylanVann please, merge this.
having the same issue in flutter, how can we solve that?