DylanC

Results 85 comments of DylanC

Dup of clinicjs/node-clinic#440

@goto-bus-stop @jasnell - Feel free to close this one if the concept/idea of Presentation Mode needs to be taken back to the drawing board.

@goto-bus-stop - A bit yeah. I'll look through the code base and make sense of how this is working regarding your comment.

@goto-bus-stop - I have the parameter collectDelay filtering all the way down to my copy of 0x. https://github.com/DylanC/0x/tree/collect_timeout_feature I also have some sudo code inside `v8-log-to-ticks.js`. Just need to implement...

@goto-bus-stop - Just investigating the CI failure. Its not due to linting but detect-port.test seems to be failing. > test/detect-port.test.js ........[eval]:1 throw new Error() ^ Error at [eval]:1:7 at Script.runInThisContext...

@goto-bus-stop - I have one error left to resolve for this change. In test/cmd-collect-delay.test.js: > test/detect-port.test.js ........[eval]:1 throw new Error() ^ Error at [eval]:1:7 at Script.runInThisContext (vm.js:122:20) at Object.runInThisContext (vm.js:329:38)...

@goto-bus-stop - Not sure what happened but the CI seems to be stuck. 3 did pass after the last collect delay increase.

@orion777 - Hi there, Not yet. We have a new release only just out now. The features you are looking for like Layer support are really big and will break...

@orion777 - Hi there, well at first we were going to drop Ubuntu 16.04 support. (Mint 18) since both Ubuntu 18.04 and Mint 19 will be out soon. Will you...

@orion777 - No problem. We can do a Mint 18 release for you. :)