link icon indicating copy to clipboard operation
link copied to clipboard

Stop flags disappear when changing linked file

Open e9gille opened this issue 1 year ago • 3 comments

I thought this was working already, but I can see that changing a linked file clears the stop (and trace/monitor) flags. Looks like this was fixed and then removed back in v2 and I know there's work to revamp this in v4, but any chance we can get this fixed in v3.0?

https://github.com/Dyalog/link/blob/76901ed4be3d2362c325d3f8b8087460a3f3f93b/StartupSession/Link/Utils.apln#L730

e9gille avatar Sep 04 '23 12:09 e9gille

Re-instated lines 703-705 and 714-716 in file below. It seems to work as expected, but do you recall why they were taken out? I fear they caused issues seeing as they are commented out. https://github.com/Dyalog/link/blob/3.0/StartupSession/Link/Utils.apln#L703

e9gille avatar Sep 04 '23 14:09 e9gille

This is where they were taken out https://github.com/Dyalog/link/commit/d0863e115dac7db72196bbb113230b8fa9ed6d6e

e9gille avatar Sep 04 '23 14:09 e9gille

Having tested this it looks like there is very little overhead in running the re-instated lines, so they were probably not removed for performance reasons.

e9gille avatar Sep 12 '23 09:09 e9gille