dwolla-swagger-php icon indicating copy to clipboard operation
dwolla-swagger-php copied to clipboard

ApiClient::deserialize has an unhandled DateTime Exception

Open cpiggott opened this issue 5 years ago • 0 comments

In the ApiClient::deserialize the new \DateTime($data); can potentially throw an exception, but it’s not caught in code.

It’s also not documented in the PHPDoc that it could throw an exception, so it’s not caught anywhere throughout the code-base.

What is your protocol here? Catch the exception and give some other date(Doesn't seem like a great idea to me...) or allow the exception be thrown?

ApiClient::L443

cpiggott avatar Feb 27 '19 20:02 cpiggott