Daniël van de Giessen

@mohammed-anwar404 I think it hasn't been addressed yet, I still see binary body data in Sentry.

Just checked. Yes, I'm still seeing this (got one issue in my stream just a few days ago) and still think the brainstormed improvements will help alleviate this.

Thanks for the feedback! > * I would suggest fixing the indentation issue you have for `optional QMI8658Options qmi8658Options = 28;` in `config.proto` to match the others. Fixed! I didn't...

I haven't yet made time to continue work on this, but have not forgotten about it. > what do you think it would take to get this one done? Aside...

I kept it in the same style as `LFS_MALLOC` and `LFS_FREE` which also use this pattern, so it's consistent between all these macro's / function signatures. Changing how one can...

Thank you for the first look! I've addressed the minor ones for now. A few CI failures are expected, for example for the cc3200 port the code simply cannot be...

> > the list of constants in network_wlan.c > > they weren't updated for the last couple of versions either Since I did the v5.2 PR (#13775) I looked into...

Just updated my tree with these commits, building against the latest IDF v5.3.1, and can confirm it seems to be running well so far.

Note: #16169 has broken building against 5.3 due to https://github.com/espressif/esp-idf/commit/f35ec64a0b1920eff91c01107fed1aee6e7a129a having renamed the `SOC_TOUCH_VERSION_x` macros.

A small change that seems to fix that: 0001-esp32-Fix-machine_touchpad-compiling-on-IDFv5.3.patch ```diff From 49de284d2896bf209fe255a26c304af55ba13fa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20de=20Giessen?= Date: Tue, 3 Dec 2024 11:08:13 +0100 Subject: [PATCH] esp32: Fix...