nightfall icon indicating copy to clipboard operation
nightfall copied to clipboard

ffmpeg 6.0 support and new baseline dependency

Open niamu opened this issue 1 year ago • 3 comments

ffmpeg 6.0 renames hls_ts_options to hls_segment_options

This change is not backwards compatible with older versions of ffmpeg so I understand if this isn't something we're ready to adopt yet.

Assuming this is accepted, https://github.com/Dusk-Labs/dim/commit/f67994d3d2bdfbf11ef7b5a1493d9d196b5832b4 changes to.github/workflows/Dockerfile.ci will need to be reverted.

This will also properly close:

  • https://github.com/Dusk-Labs/dim/issues/554
  • https://github.com/Dusk-Labs/dim/issues/547

niamu avatar Aug 14 '23 23:08 niamu

Can we put this behind a feature flag for now? We should support this just not sure how to get the appropriate changes to Dim's releases done for now.

mental32 avatar Nov 07 '23 10:11 mental32

you could check the available ffmpeg version while staring dim

a22sc avatar Nov 21 '23 23:11 a22sc

Fast bandaid is we can use jellyfin-ffmpeg that already a pretty comprehensive release, https://github.com/jellyfin/jellyfin-ffmpeg/releases/tag/v6.0-8. Further, we can focus on the application, rather than be stuck at old ffmpeg, which may not be desirable. In-house build is good but time is our enemy.

martadinata666 avatar Nov 24 '23 03:11 martadinata666