Whisper icon indicating copy to clipboard operation
Whisper copied to clipboard

Published 20 hours ago • verified publisher icon Dun-sin

feat: Add custom dialog

Open Manethpak opened this issue 2 years ago • 6 comments

Fixes Issue

My PR closes #177

👨‍💻 Changes proposed(What did you do ?)

Create a new Dialog component that will be used throughout the project instead of using browser's native alert. Screenshot below show what the dialog looked like added to the logout and chat close function.

✔️ Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [x] This PR does not contain plagiarized content.
  • [x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

image

image

Manethpak avatar Oct 23 '22 08:10 Manethpak

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

vercel[bot] avatar Oct 23 '22 08:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
whisper ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 9:07AM (UTC)

vercel[bot] avatar Oct 23 '22 09:10 vercel[bot]

Doesn't look good on mobile

Screenshot_2022-10-23-10-10-25-387_com.brave.browser.jpg

Dun-sin avatar Oct 23 '22 09:10 Dun-sin

Also pls pull the latest changes to this and make sure they work properly

  • edit doesn't work
  • typing status is buggy

Just to be safe

Dun-sin avatar Oct 23 '22 09:10 Dun-sin

Thank for the feedback, I'll check on the point that you mentioned

Manethpak avatar Oct 23 '22 09:10 Manethpak

@Dun-sin As you mentioned

  • I have fixed the dialog to be more responsive
  • Refactor it to has typehint I'm not quite sure what do you mean by edit doesnt work but if you could elaborate it here, I'm happy to work on it. Sorry if I make a lot of mistake I'm new to open-source contribution, so if you could bare with me.

Manethpak avatar Oct 24 '22 15:10 Manethpak

@Manethpak great work, but why not just use the dialog component provided by RSuite? It's mobile responsive and can be customized, plus it already being used in the app...

mathiasayivor avatar Oct 24 '22 19:10 mathiasayivor

@mathiasayivor That was my bad, I didn't know you had a UI library installed. I read through the project's code and mostly the UI are all written by hand that's why I decided to write one as well

Manethpak avatar Oct 25 '22 05:10 Manethpak

@mathiasayivor That was my bad, I didn't know you had a UI library installed. I read through the project's code and mostly the UI are all written by hand that's why I decided to write one as well

@Manethpak still doesn't look good on mobile image

Dun-sin avatar Oct 25 '22 10:10 Dun-sin

@Manethpak also can you close this PR and try to push to the test branch instead of the main, so I can see where the issues I noticed are coming from

Dun-sin avatar Oct 25 '22 10:10 Dun-sin