Legend_of_the_Invincibles icon indicating copy to clipboard operation
Legend_of_the_Invincibles copied to clipboard

Published 20 hours ago • verified publisher icon Dugy

parry bool vs int

Open white-haired-uncle opened this issue 9 months ago • 2 comments

Is this going to work for drains? First ihas_drain is set to 0, then it might be set to yes, then checks if it's == 1.

If has_drain was defined as a bool I could see it, assuming wml considers 1/yes/true(?) equivalent. But honestly I have no idea what has_drain is at any point (string, int, bool). Does it even have a type, or just guess based on (current) usage?

Whatever the answer, I don't like it. IMO it would make more sense to just use yes/no.

https://github.com/Dugy/Legend_of_the_Invincibles/blob/5f9d6ce6ef4d80338f011232ef586fd46e0c694a/utils/abilities_events.cfg#L1556-L1649

white-haired-uncle avatar May 12 '24 14:05 white-haired-uncle