Legend_of_the_Invincibles icon indicating copy to clipboard operation
Legend_of_the_Invincibles copied to clipboard

Consider switching to wesnoth.effects for some properties

Open Discontinuum opened this issue 1 year ago • 1 comments

Some properties happen to have a built-in support in wesnoth.effects from 1.14, so maybe we can switch to using built-in ones (although the code in stas.lua probably have to stay for supporting legacy saves).

Among them are vision (apply_to=vision), max_attacks (in docs max_attacks with increase= key while LotI uses add), alignment (LotI items use

[effect]
apply_to=alignment
alignment=chaotic
[/effect]

while Wesnoth docs define the built-in alignment effect as

[effect]
apply_to=alignment
set=chaotic
[/effect]

Discontinuum avatar Jul 12 '23 03:07 Discontinuum

Yes, that would make sense.

Dugy avatar Jul 12 '23 07:07 Dugy