IdentityServer icon indicating copy to clipboard operation
IdentityServer copied to clipboard

Prevent misuse of IdentityProviders

Open josephdecock opened this issue 1 year ago • 2 comments

Sometimes when users have tried to implement dynamic providers with custom stores, there's a confusion about the intended usage of IdentityProvider vs its derived types.

@josephdecock maybe we could do better in the code to detect this type of thing? and maybe emit more helpful logs?

Originally posted by @brockallen in https://github.com/DuendeSoftware/Support/issues/556#issuecomment-1466469687

josephdecock avatar Mar 13 '23 16:03 josephdecock

First thought - make IdentityProvider abstract (obviously that's a breaking change though)

josephdecock avatar Mar 13 '23 16:03 josephdecock

Our first attempt at ensuring people follow the right pattern was via our sample (WS-Fed one IIRC). Is that not enough?

brockallen avatar Nov 16 '23 18:11 brockallen