Duende.AccessTokenManagement icon indicating copy to clipboard operation
Duende.AccessTokenManagement copied to clipboard

Published 20 hours ago • verified publisher icon DuendeSoftware

Add Authority to ClientCredentials options

Open josephdecock opened this issue 9 months ago • 6 comments

Adds a new authority option. If it is set, we use it to retrieve the discovery document, and use that to configure the token endpoint. Because this is an async operation, we have a new abstraction for retrieval of the token endpoint

Closes #28

josephdecock avatar May 03 '24 20:05 josephdecock

Hmm.... ok, so do you think this is too complicated or problematic to pursue? IOW, is this worth all the new goo?

brockallen avatar May 03 '24 21:05 brockallen

Hmm.... ok, so do you think this is too complicated or problematic to pursue? IOW, is this worth all the new goo?

I'm unsure ... frankly was hoping for strong reactions to this PR 😆

It does feel kind of unnecessary, especially if I add discovery policy and cache timeout.

@leastprivilege, @AndersAbel, what do you guys think?

josephdecock avatar May 04 '24 03:05 josephdecock

I think it is not the concern of this library to do discovery...

leastprivilege avatar May 05 '24 12:05 leastprivilege

Ok, then let's close this and #28.

josephdecock avatar May 05 '24 19:05 josephdecock

I think it is not the concern of this library to do discovery...

At least not for this round of updates...

leastprivilege avatar May 05 '24 19:05 leastprivilege

Okay, I'll leave this as a draft PR for the future

josephdecock avatar May 05 '24 20:05 josephdecock