Dmitriy Dudkevich

Results 91 comments of Dmitriy Dudkevich

Hm, I use - `MacBook Pro 16-inch, 2019; CPU: 2,6 GHz 6-Core Intel Core i7; Memory: 32 GB 2667 MHz DDR4`. And I cannot make it faster =( Which device...

> The strategy is described in our documentation: https://playwright.dev/docs/api/class-pageassertions#page-assertions-to-have-screenshot-1 In documentation I see this text: ``` This function will wait until two consecutive page screenshots yield the same result, and...

> The first comparison is a shortcut that happens only if the expected exists. This way we achieve a fast comparison for a "happy-path", i.e.: Okay and even in such...

> This is because we want to stop taking screenshots as soon as we get a stable one. The stable one may or may not match original one after a...

> Which comparison you think is unnecessary if we want to stick with the algorithm that waits for the page screenshot to stabilize? I believe that stabilizing actual images in...

> @DudaGod Would you like to take a stab at the above changes? Yes.

> - [ ] move to [email protected] and higher in order to be able to install [email protected] in which libvips installed from npm and not from gh. More info here...

@robertohuertasm Hello. Can you review it and merge? Thanks.

@robertohuertasm I just want to remind you about this PR. Do you have at least a little time for it? Thanks.

@jimmywarting Hello. Can you merge it? Thank you.