StéphaneDucasse
StéphaneDucasse
These methods are only use by the refactoring engine. Let us move them there.
``` RBMoveTemporaryVariableDefinitionTransformation >> buildTransformations "ifnil... tight blocks should not be returned as errors" blockNodes ifNil: [ self checkMethodForBlocks ]. ^ (OrderedCollection withAll: ((blockNodes sorted: [ :a :b | a start...
``` privateTransform | methodTree parseTree | methodTree := self definingMethod. parseTree := methodTree body. interval ifNotNil: [ | nodeInInterval | nodeInInterval := methodTree bestNodeFor: interval. nodeInInterval isSequence ifTrue: [ parseTree...
``` SettingTreeBuilder class >> acceptableKeywords: aCollectionOfRegExps ^ self new acceptableKeywords: aCollectionOfRegExps ``` `SettingTreeBuilder acceptableKeywords: { #notetakesettings }` raises a DNU.
Once https://github.com/pharo-project/pharo/pull/18821/ is integrated we should fix the popup. We should not get a pop up in the refactoring. ``` TemporaryToInstanceVariableRefactoring >> preconditionNoSubclassDefinesVar [ ^ RBCondition withBlock: [ (class allSubclasses...
Since the refactoring version does the same and its implementation has been revisited. In addition there is not breakingChanges precondition. So ignoring them is not possible so it makes the...
- First space a leading character will not be able to be reloaded. - For spaces in the rest of the names we should start to forbid their creation.
Two points ### Add more tests. In the first place I thought that the following was wrong. But since the temp value is not accessed in the second block. It...
And add some comments. - the tests should cover read and write access.