StéphaneDucasse

In Driver we have ``` Driver>>applyChanges | applied | applied := self openPreviewWithChanges: self changes. ``` and changes ``` changes "Drivers should not call generateChanges of Refactoring because generateChanges is...

I tried ``` pullUpReferencedInstVars | compositeChange | compositeChange := RBCompositeRefactoryChange new. compositeChange name: 'pulled up instances'. self halt. ( notInstVarRefs referencedInstanceVariables do: [ :instVar | "We add the pushUpVariable refactoring...

I changed it back and change the flow of the driver but now I get method push to siblings :( ``` configureAndRunRefactoring self configureRefactoring. "Pay attention that the applicability preconditions...

This is normal. Now I got the solution. PR on its way.

Yes good idea. We also need a change browser in Spec BTW

########### # Summary # ########### IceSinglePackageLocalMemoryRepositoryTest ✗ #testListBranchCommitsListsCommitsInBranch (5ms) IceNewGitRepositoryTest ✗ #testDeleteRepositoryDeletesLocation (89ms) IceMultiplePackageLocalMemoryRepositoryTest ✗ #testListBranchCommitsListsCommitsInBranch (5ms) IceMemoryRepositoryWithSingleRemoteAndMergeConflictTest ✗ #testRepositoryHasIncomingCommitsAfterFetch (5ms) ✗ #testRepositoryHasOutgoingCommitsAfterFetch (3ms) IceTipRepositoryBrowserWithRemoteTest ✗ #testHasBranchButtonOnTheLeft (123ms) ✗ #testHasPullButtonOnTheLeft...

Oops I did not see this and I will need help to understand

Thanks!

Maybe we are the first ones to realise that Add Method is complex!

Imagine now ``` A >> x ^ 12 B >> isEmpty C>> foo ^ self x ``` Now we add in B x ^ 42 We got a behavior change.