Sandeep Dubey
Sandeep Dubey
@hrshkshri Do we need to add these ModalComponents inside shared.module?
> I thought the shared-component.module is also responsible for backend service, therefore I just tried to add modalComponent in shared-component.module.ts too Are you still facing the issue?
@hrshkshri CI builds are failing on this PR, PTAL!
@hrshkshri Lnt checks are failing on this PR, can you confirm wether pre-push hooks are working fine locally i.e, lint checks are running after `git push ` command?
> I resolved the merge conflict on GitHub itself and there was one extra Generally, we don't suggest resolving conflicts on Github (for the same reason i.e, git hooks), please...
@hrshkshri is this PR ready for review?
@hrshkshri, could you take a look at the comments under the debugging document? I'm available to assist with resolving the problem. I believe I added a crucial note that might...
> I took a pass in the debugging doc, while we are solving this particular problem can I get assigned to another page for migration ( maybe a simpler one,...
@chris7716 @lkbhitesh07 @Lawful2002 Can you please review this PR?
@shivanandan17 Make sure to reply to all the open threads: https://github.com/oppia/oppia/pull/19703#discussion_r1490122870