MALClient icon indicating copy to clipboard operation
MALClient copied to clipboard

Some stuff in the UWP version

Open Guerra24 opened this issue 8 years ago • 81 comments

New report will be added as a reply to this issue. Please do not close this issue. UWP edition of #121.

Icons:

  • 🐞 Bug - It doesn't do what it's supposed to do, required to fix (feature issues, crashes)
  • 🐝 Bee - I want it to look better, not required to fix (ui, animation, etc)
  • 🍄 Mushroom - Feature Request/Suggestion
  • 💙 Blue Heart - I like it! General Feedback

Feel free to edit.


  • 🐞 Typo in "sort values".
    • ✔️ Fixed
  • 🐝 Highlight is way too transparent.
    • ✔️ Fixed
  • 🍄 Move the back arrow to the window frame.
    • ✔️ Fixed
  • 🐝 Images in articles should be cropped or scaled instead of stretched (it looks bad).
    • ✔️ Fixed
  • 🐝 Bottom bar position; left is how looks now, right is how it should be. Image
    • ✔️ Fixed
  • 🐝 The bottom bar changes color in the "Images" view.
    • ✔️ Fixed
  • 🐞 Going into "Anime recommendations" crashes the app (Fix ASAP).
    • ✔️ Fixed
  • 🍄 Make the Title Bar use the accent color, only when the window is active.
    • ✔️ Use acrylic
  • 🐝 Scrollbar arrows still appear even if the list does not exceed the max size. Vid. This is in the "History" view.
    • ✔️ Fixed
  • 🐝 With some accent colors the highlight makes the text impossible to read.
  • 🐝 Scrollbar should stick to the window border. Now, how it should
    • ✔️ Fixed
  • 🐝 Anime images (right side) should be cropped or scaled instead of stretched (it looks bad).
    • ✔️ Fixed
  • 🐝 Calendar highlight doesn't mach and the icon doesn't move with the background. Video
    • Well, I see why.
  • 🐝 Closing the settings doesn't restore to the previous selected item in the hamburger menu. Video
  • 🐞 Clicking an item multiple times will reload the view even if it is already loaded. Video
  • 🐝 Drag to increase/decrease uses all available mouse buttons, some of them (middle click or custom) doesn't trigger the click animation.
    • UWP Bug...
  • 🐞 Missing delete button when adding new anime to list. Video
  • 🐞 The "clear image cache" is ultra slow and gets cancelled when the app is closed.
  • 🍄 Use the entire button for the date selector. Video
  • 🐞 Season selector partially broken. Video
  • 🐞 Character name with special "symbols". Image
  • 🐞 Forum posts broke. Image
    • ✔️ Fixed
  • 🐝 Why not integrate the top area (hamburger button, list name and anime name) into the titlebar?
    • ✔️ Implemented.

Guerra24 avatar Apr 19 '17 06:04 Guerra24

I'll do this on Friday probably, where can I order 2nd pair of hands? ;d

Drutol avatar Apr 20 '17 07:04 Drutol

Update: well I've caught a cold and I was unable to do anything today :(

Drutol avatar Apr 21 '17 20:04 Drutol

The Anime recommendations crash still happens, at least for me. Vid

Guerra24 avatar Apr 24 '17 22:04 Guerra24

Does window size has anything to do with recommendations crashing?

Drutol avatar Apr 25 '17 07:04 Drutol

No, maximized or any other size still crashes.

Guerra24 avatar Apr 25 '17 07:04 Guerra24

And it changes to the different mode when it has more space before crash?

Drutol avatar Apr 25 '17 07:04 Drutol

Yes, if maximized it shows the bottom bar.

Guerra24 avatar Apr 25 '17 07:04 Guerra24

Hmm, is any of these devices yours?

image image

Drutol avatar Apr 26 '17 04:04 Drutol

No, I'm using a custom pc.

Guerra24 avatar Apr 26 '17 05:04 Guerra24

I would say that the UWP app is broken, since I have some free time I will start working on fixing this. I don't know much about UWP but have used C# in the past.

Guerra24 avatar May 13 '17 00:05 Guerra24

Yes, I've fixed this but I was waiting on feedback regarding freezes so I didn't push an update yet.

Drutol avatar May 13 '17 04:05 Drutol

I mean, fix all they issues listed here.

Guerra24 avatar May 13 '17 05:05 Guerra24

Oh okay, good luck, getting some help would be huge booster ^^ I was on my phone so I couldn't edit it as I usually do.

Drutol avatar May 13 '17 05:05 Drutol

The resizing crash... Visual Studio is unable to handle the exception, I'm unable to debug this crash. Looks that is something in the win32 side, way below in the system. SO, this bug is here from the beginning (most probably) or was introduced with an update.

Guerra24 avatar May 14 '17 22:05 Guerra24

The anime list system isn't the issue, it works correctly. There is something that gets triggered at a specific size.

Guerra24 avatar May 14 '17 23:05 Guerra24

Noooo please no... I've been fighting with this once for a long time... in the end it turned out that for some reason pivot with "Watching,Completed" etc was causing it when its index was set via binding. It was pure luck back then.

No wonder crash reporting isn't helpful...

Drutol avatar May 15 '17 03:05 Drutol

And the "Anime recommendations" crash caused by an "Access Violation Exception" img

Guerra24 avatar May 15 '17 05:05 Guerra24

Pivot again...

Drutol avatar May 15 '17 06:05 Drutol

Try removing custom styles from these pivots?

Drutol avatar May 15 '17 06:05 Drutol

How is it going?

Drutol avatar May 19 '17 16:05 Drutol

Now I hate visual studio, just saying xD. The VS project system is awful.

Guerra24 avatar May 20 '17 00:05 Guerra24

And yes, removing the custom styles fixes the crash. Video

EDIT: After some testing the source of the crash are the Selection States, removing that code fixes the crash.

EDIT2: Recommendations crash is the same, removing the selection states fixes it. Video

Guerra24 avatar May 20 '17 01:05 Guerra24

Well I don't see any issue with project structure in vs. For me the java one is much more messy.

Vs is mediocre without ReSharper though.

I'll look into it today, thanks! ^^

Drutol avatar May 20 '17 03:05 Drutol

Hmm I was unable to check it out because "android open beta"... I will though as soon as I can

Drutol avatar May 22 '17 15:05 Drutol

It looks like MS changed pivot style completely with some update...

Drutol avatar May 23 '17 08:05 Drutol

I want to rewrite everything so badly now that I see some things that were here from day-one, god what monstrosity is this...

Drutol avatar May 23 '17 08:05 Drutol

Nothing has changed in HeaderItem which has these styles though...

Drutol avatar May 23 '17 08:05 Drutol

They won't work because I don't have the data yet while arranging these items, once the data is here notice that they are sorted correctly.

Drutol avatar Jun 15 '17 07:06 Drutol

mmm... if that's the case, it needs the "Load all details" button or triggering the "load details" when sorting.

Guerra24 avatar Jun 15 '17 07:06 Guerra24

It would require too many requests, if user wants to have everything pulled he just needs to: image

Drutol avatar Jun 15 '17 07:06 Drutol