BFColorPickerPopover icon indicating copy to clipboard operation
BFColorPickerPopover copied to clipboard

_delegatePopoverShouldClose not called in Yosemite

Open graphiclife opened this issue 10 years ago • 1 comments

The method

- (BOOL)_delegatePopoverShouldClose:(id)sender

(BFColorPickerPopover:182) is not called in Yosemite when the popover is dismissed by clicking outside, and thus the popover keeps observing changes on the shared color picker, creating some weird behaviour.

graphiclife avatar Nov 19 '14 12:11 graphiclife

I've also noticed this and found that implementing - (BOOL)popoverShouldClose:(id)sender instead does seem to work correctly. However I'm not sure why _delegatePopoverShouldClose was used, so I can't say for certain that this is the correct approach...

lemonmojo avatar Nov 21 '14 10:11 lemonmojo