R Gibim

Results 82 comments of R Gibim

Method completion and jump-to-method-definition is the only thing currently holding me to other alternatives. I am anxiously looking towards this feature to jump on ruby-lsp boat! 🛥️ 🛥️ Thank you...

@rud From what I've attempted I just couldn't make Actions V2 (responses/requests) work with Login V1. So unfortunately the only options I see are: * stick to Actions V1 if...

Any updates on this? Setting up executions on specific methods didn't have any effect with Login V1 (I've updated my reproduction repo to reflect this) Since updating to login v2...

Just tested v4.7.1 and the issue seems to still exist (under Login V1)

Just to update with current behaviour: it seems now (v2.22.0) that order is irrelevant and the framework always overwrite the sub-parts configurations. Reproduction script: ```ruby require "datadog" require "rails" Datadog.configure...

Also worth noting: this behaviour also affects the [Karafka framework](https://github.com/DataDog/dd-trace-rb/blob/master/lib/datadog/tracing/contrib/karafka/framework.rb), making it hard to disable distributed_tracing on message consumption (`karafka` integration) while keeping it enabled on message production (`waterdrop` integration)....

Hey @p-datadog 👋 Apologies - I've left `ApplicationConsumer` there but you can replace it for `Karafka::BaseConsumer`. Also I haven't really mentioned but you should: * make sure Apache Kafka (or...

> Should we be dropping the waterdrop min version in this PR? @ericfirth Not sure about that 🤔 Short answer: I'm fine with that, but this decision has to come...

Hey @marcotc @ivoanjo can you have a quick look here please? 🙇 Would like to get this merged to not conflict with other Karafka/Waterdrop pull requests (e.g.: DataDog/dd-trace-rb#4874 - and...

Coming back to this now - apologies for the delay 🙇 > do you feel about moving the span link code into a separate PR and just leaving the fix...