conference-app-2024 icon indicating copy to clipboard operation
conference-app-2024 copied to clipboard

Scroll is not possible when Favorite is Empty in FavoriteScreen.

Open kosenda opened this issue 6 months ago • 2 comments

Overview

When Favorite is Empty on a FavoriteScreen, it indicates that there are no favorites, but not all of the content may be displayed because it is not a Scrollable screen.

example: Pixel6 + DisplaySize max + FontSize max + splitScreen

Might be helpful

I think we can fix it by simply setting Scrollable here

https://github.com/DroidKaigi/conference-app-2024/blob/a1a0fdc8d53d1bb078644e4a0ae661feecf9b08f/feature/favorites/src/commonMain/kotlin/io/github/droidkaigi/confsched/favorites/section/FavoriteSheet.kt#L104-L142

kosenda avatar Aug 16 '24 07:08 kosenda