conference-app-2023 icon indicating copy to clipboard operation
conference-app-2023 copied to clipboard

Published 20 hours ago • verified publisher icon DroidKaigi

[Android] Add title for the license screen

Open fumiya-kume opened this issue 1 year ago • 4 comments

Idea Description

Replace to suitable title for the OSS license screen.

Difficulty

Currently, app-android module not yet setup the String resources management system which using StringsBindings.
For this situation, you have to do following items.

  • Setup with StringsBindings at app-android module
  • Call OssLicensesMenuActivity.setActivityTitle with added string

You can refer Official documents as well

Reference images and links

fumiya-kume avatar Aug 24 '23 11:08 fumiya-kume

There is AppStrings class so we can utilize it 🙏

takahirom avatar Aug 26 '23 08:08 takahirom

Sorry, I want to try this issue 🙇

fumiya-kume avatar Aug 28 '23 14:08 fumiya-kume

Thanks!

takahirom avatar Aug 29 '23 01:08 takahirom

I'd like to confirm the dead line of this task. Is there any strict deadline? If no, I'd like to try some of improvements with this issue.

Such as (I will reduce the item which low priority maybe

  • Move to own feature module (I won't expand the app module)
  • Fix plugin name by PR review on previous PR 🙇
  • Make screen by Jetpack compose inspired by this blog post
  • Optimize for the foldable devices

fumiya-kume avatar Aug 29 '23 04:08 fumiya-kume