conference-app-2023 icon indicating copy to clipboard operation
conference-app-2023 copied to clipboard

Published 20 hours ago • verified publisher icon DroidKaigi

Can't see the `TimetableList` or `TimetableGrid` when the phone is in landscape mode.

Open kosenda opened this issue 1 year ago • 7 comments

Sorry if this is a known bug.

Describe the bug Can't see the TimetableList or TimetableGrid when the phone is in landscape mode.

https://github.com/DroidKaigi/conference-app-2023/blob/898f3bb57cb7d7f79c8ab584651f2ee101d07dc5/feature/sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/section/TimetableSheet.kt#L91

To Reproduce Steps to reproduce the behavior:

  1. Launch the application
  2. Turn the screen sideways

Expected behavior TimetableList or TimetableGrid is visible.

Screenshots phone: Pixel6

https://github.com/DroidKaigi/conference-app-2023/assets/60963155/fbb2906c-c17e-454b-9817-e2c21757b79f

kosenda avatar Aug 15 '23 13:08 kosenda

I didn't notice this! Thanks!

takahirom avatar Aug 15 '23 13:08 takahirom

@takahirom 🙋 I'd like to try this issue!

Masaki-U avatar Aug 16 '23 18:08 Masaki-U

@Masaki-U Thank you for your interest ✨ I Assigned you.

mhidaka avatar Aug 16 '23 19:08 mhidaka

@takahirom @mhidaka It seems to me that this issue has been resolved by moving the bottom bar to the sidebar in landscape mode. How do you see it? Regarding the implementation status, I have resolved it everywhere except for our custom LazyLayout grid timetable, but after that, it's been challenging.

https://github.com/DroidKaigi/conference-app-2023/pull/968

https://github.com/DroidKaigi/conference-app-2023/assets/42033804/de8bb677-7c59-4426-843a-37b051745a3a

Masaki-U avatar Aug 26 '23 02:08 Masaki-U

@Masaki-U I think we can remove this issue! How about adding a screenshot test for the landscape timetable to check continually?

takahirom avatar Aug 27 '23 15:08 takahirom

Excuse me for jumping in :pray:

If running on NexusOne (using it for Roborazzi snapshot test), it seems navbar is displayed at bottom on screen. :thinking: (maybe due to the NexusOne's screen size)

nexusone.webm

And if you run on little bit larger device (i.e. PixelXL), navigation rail will change layout as following. (additional landscape screenshot sample on PixelXL)

How do you think we should handle this??

ked4ma avatar Sep 08 '23 08:09 ked4ma

We used Nexus One to save money when we are closed source. So we don't have to think about Nexus One anymore. It is better to support small devices though. 👀

takahirom avatar Sep 08 '23 09:09 takahirom