conference-app-2023 icon indicating copy to clipboard operation
conference-app-2023 copied to clipboard

Improve foldable devices support for TimeTable screen.

Open fumiya-kume opened this issue 1 year ago • 7 comments

Idea Description

The current experiences with the foldable devices is enough, However we can consider to optimize it as well. In fact. Google want to push the app that optimize it, then We can try to the edge as first penguin!

Ref: https://android-developers.googleblog.com/2023/07/introducing-new-play-store-for-large-screens.html

As offer a basis for discussion, I'd like to recommend to apply the List-detail pattern for the screen. since the Time table screen has Main and detail screen then.

I know that require discussion and making the design, but I believe it will good benefit for the Android developers.

Ref: https://m3.material.io/foundations/layout/canonical-layouts/list-detail

Reference images and links

Current experiences at Timetable screen *Pixel Fold

fumiya-kume avatar Aug 14 '23 12:08 fumiya-kume

Thank you for the suggestion, @fumiya-kume!

The idea of implementing the List-detail pattern for the TimeTable screen is indeed interesting, and it seems to align well with our goal to enhance the experience for foldable devices. I would like to discuss this approach with the designer to ensure that it integrates well with the overall vision for the app.

Your input is incredibly valuable, and I appreciate you taking the initiative to propose this change. Let's continue to collaborate as we explore this idea further.

takahirom avatar Aug 14 '23 12:08 takahirom

Thank you for picking up my feedback 🙇

In addition, Navigation rail is working well with foldable devices. Definitely, better than NavigationBar / BottomNabigationBar when using the foldable devices.

Ref: https://m3.material.io/components/navigation-rail/overview

fumiya-kume avatar Aug 14 '23 12:08 fumiya-kume

If assignee is empty, I want to try this issue.

l2hyunwoo avatar Aug 17 '23 05:08 l2hyunwoo

Sure! Thank you for showing the interest! Assigned you!

upon0426 avatar Aug 17 '23 05:08 upon0426

@upon0426 I think it can consider to separate two parts.

  • Phase 1: Apply Navigation Rail when foldable device expanded
  • Phase 2: Apply List-Detail Pattern

Make two tasks in one PR can cause decreased readability and increased complexity. So I think make two PRs in each phase is better to proceed. Would it be okay to do that?

l2hyunwoo avatar Aug 19 '23 02:08 l2hyunwoo

Thank you for the consideration! Yes, separate PR sounds good to me as well for this kind of case. Please proceed that way 👍

upon0426 avatar Aug 19 '23 02:08 upon0426

@l2hyunwoo We've added the design for tablet or foldable. Please take a look 🙏 image https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&mode=design&t=vOJjBNAfJ23KUuSF-0

takahirom avatar Aug 21 '23 00:08 takahirom