conference-app-2023
conference-app-2023 copied to clipboard
Hide title when enable the BigFont/BigDisplay in ContributorsScreen
Issue
- close #1150
Overview (Required)
- Using AutoSizableText no longer causes character breaks.
Links
- AutoSizing TextField in Jetpack compose
- https://github.com/DroidKaigi/conference-app-2023/pull/1149
Screenshot (Optional if screenshot test is present or unrelated to UI)
When BigFont/BigDisplay is disabled, Before and After are different, but as far as Figma shows, the same Style is applied, so I do not think there is any problem. https://www.figma.com/file/MbElhCEnjqnuodmvwabh9K/DroidKaigi-2023-App-UI?type=design&node-id=55032-59308&mode=dev
Settings | Before | After |
---|---|---|
Test Results
215 tests 215 :heavy_check_mark: 6m 38s :stopwatch: 11 suites 0 :zzz: 11 files 0 :x:
Results for commit 0769262e.
:recycle: This comment has been updated with latest results.
Could you add screenshot tests for this? Maybe we could break this unexpectedly 🙏
@takahirom Sorry, I was not able to make a screenshot 🙇 So, I would like to either raise an issue to add a new test or not close this issue.
Since there was no screenshot test for ContributorsScreen
, I first tried to create a ContributorsScreenRobot
, but I could not prepare a ContributorsViewModel to test it.
If I set = hiltViewModel()
as the default argument for ContributorsViewModel
in ContributorsScreen
as I do for other screens, I can test ContributorsScreenRobot
with ContributorsViewModel
in ContributorsScreenRobot
, but I gave up because I couldn't get the dependencies right.
I think you can try to use androidMain { dependencies { implement(libs.xxxx) } }
👀
Thank you! I'll try it!
Sorry, we should use androidUnitTest like this. Because androidMain will affect the main artifact.
androidUnitTest {
dependencies {
}
}
@takahirom Sorry for repeating 🙇 I have tried test, but I don't know how to test it at all, so I would like to either create a new issue for testing or not close the issue.