conference-app-2023
conference-app-2023 copied to clipboard
Improve OSS licenses screen
Issue
- close #938
Overview (Required)
- Add OssLicenseScreen to list up the libraries
- Add OssLicenseDetailScreen to show the license contents
- Parsing the generated contents from the Google's licenses plugin.
TODO
- [x] Replace Screen title handling
- [x] Remove Licenses position from the domain model
- [x] Refactoring library grouping logic
- [x] Align naming rule for the license/library
- [x] Add implementation for navigation up
- [x] Improve Card expand state handling
- [ ] Support Large screen devices
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Before | After |
---|---|
Movie (Optional)
Before | After |
---|---|
Test Results
218 tests 218 :heavy_check_mark: 8m 39s :stopwatch: 13 suites 0 :zzz: 13 files 0 :x:
Results for commit ecd9b9f8.
:recycle: This comment has been updated with latest results.
(Fixing the DI config :loading:
I think you can refer to what we did for app version. https://github.com/search?q=repo%3ADroidKaigi%2Fconference-app-2023%20BuildConfigProvider&type=code
Hi @fumiya-kume! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct
and fix the results of ./gradlew lintDebug.. Thank you for your contribution.
Could you add a screenshot test for this screen? This is because all other screens have one, and this PR causes our test coverage to shrink. 🙇
Snapshot diff report
File name | Image |
---|---|
OssLicenseDetailScre enTest.checkLaunchSh ot_compare.png |
![]() |
OssLicenseScreenTest .checkLaunchShot_com pare.png |
![]() |