conference-app-2023 icon indicating copy to clipboard operation
conference-app-2023 copied to clipboard

Improve OSS licenses screen

Open fumiya-kume opened this issue 1 year ago • 6 comments

Issue

  • close #938

Overview (Required)

  • Add OssLicenseScreen to list up the libraries
  • Add OssLicenseDetailScreen to show the license contents
  • Parsing the generated contents from the Google's licenses plugin.

TODO

  • [x] Replace Screen title handling
  • [x] Remove Licenses position from the domain model
  • [x] Refactoring library grouping logic
  • [x] Align naming rule for the license/library
  • [x] Add implementation for navigation up
  • [x] Improve Card expand state handling
  • [ ] Support Large screen devices

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

fumiya-kume avatar Aug 29 '23 14:08 fumiya-kume

Test Results

218 tests   218 :heavy_check_mark:  8m 39s :stopwatch:   13 suites      0 :zzz:   13 files        0 :x:

Results for commit ecd9b9f8.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 29 '23 14:08 github-actions[bot]

(Fixing the DI config :loading:

fumiya-kume avatar Sep 12 '23 14:09 fumiya-kume

I think you can refer to what we did for app version. https://github.com/search?q=repo%3ADroidKaigi%2Fconference-app-2023%20BuildConfigProvider&type=code

takahirom avatar Sep 13 '23 01:09 takahirom

Hi @fumiya-kume! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

github-actions[bot] avatar Sep 16 '23 06:09 github-actions[bot]

Could you add a screenshot test for this screen? This is because all other screens have one, and this PR causes our test coverage to shrink. 🙇

takahirom avatar Sep 18 '23 08:09 takahirom