conference-app-2022 icon indicating copy to clipboard operation
conference-app-2022 copied to clipboard

Add preview test

Open sobaya-0141 opened this issue 2 years ago • 11 comments

Overview (Required)

  • ScreenshotTest by Paparazzi added

Links

  • https://github.com/android/nowinandroid/pull/101

sobaya-0141 avatar Sep 02 '22 14:09 sobaya-0141

Related paparazzi Issues https://github.com/cashapp/paparazzi/issues/565 https://github.com/cashapp/paparazzi/issues/489#issuecomment-1195674603

sobaya-0141 avatar Sep 03 '22 12:09 sobaya-0141

Please make sure that the addition of screen shots are not in the history due to the repository size. I think you can rebase and squash the commit. 🙏

takahirom avatar Sep 04 '22 15:09 takahirom

There is a Diff in the screenshot

github-actions[bot] avatar Sep 05 '22 07:09 github-actions[bot]

There is a Diff in the screenshot

github-actions[bot] avatar Sep 05 '22 11:09 github-actions[bot]

There is a Diff in the screenshot

github-actions[bot] avatar Sep 05 '22 11:09 github-actions[bot]

There is a Diff in the screenshot

github-actions[bot] avatar Sep 05 '22 11:09 github-actions[bot]

There are differences in Compose previews. Please check your build and download the diff artifact. https://github.com/DroidKaigi/conference-app-2022/actions/workflows/ScreenShotTest.yml

github-actions[bot] avatar Sep 05 '22 12:09 github-actions[bot]

Conflicts resolved.

sobaya-0141 avatar Sep 06 '22 02:09 sobaya-0141

There are differences in Compose previews. Please check your build and download the diff artifact. https://github.com/DroidKaigi/conference-app-2022/actions/workflows/ScreenShotTest.yml

github-actions[bot] avatar Sep 06 '22 02:09 github-actions[bot]

There are differences in Compose previews. Please check your build and download the diff artifact. https://github.com/DroidKaigi/conference-app-2022/actions/runs/2998394718

github-actions[bot] avatar Sep 06 '22 07:09 github-actions[bot]

Comment & Conflicts resolved.

sobaya-0141 avatar Sep 06 '22 09:09 sobaya-0141

There are differences in Compose previews. Please check your build and download the diff artifact. https://github.com/DroidKaigi/conference-app-2022/actions/runs/3014753123

github-actions[bot] avatar Sep 08 '22 11:09 github-actions[bot]

Commit history has been reorganized and made available for review.

sobaya-0141 avatar Sep 08 '22 12:09 sobaya-0141

@sobaya-0141 I commented on some points 🙏 Could you please take a look at the comment?

takahirom avatar Sep 09 '22 03:09 takahirom

Thank you for your review. We will respond to it now. Please wait for a while.

sobaya-0141 avatar Sep 11 '22 03:09 sobaya-0141

I fixed the conflict in GitHub.

takahirom avatar Sep 14 '22 00:09 takahirom

@sobaya-0141 If you don't have time, we can develop this PR by recruiting contributors to this PR. What do you think?

takahirom avatar Sep 14 '22 00:09 takahirom

@takahirom Let me do it until 10:00 today. If I cannot complete it by then, please assign it to someone else.:bow:

sobaya-0141 avatar Sep 14 '22 00:09 sobaya-0141

I can't seem to find the time, so let me give it up.:bow::bow::bow:

sobaya-0141 avatar Sep 14 '22 02:09 sobaya-0141

Let's merge!

takahirom avatar Sep 15 '22 04:09 takahirom