conference-app-2022 icon indicating copy to clipboard operation
conference-app-2022 copied to clipboard

Replace montserrat font resource with downloadable font

Open NUmeroAndDev opened this issue 2 years ago • 6 comments

Idea Description

  • Replace montserrat's font resource with downloadable font.
  • And want to add the weight of the font with W500 and W400 when making downloadable font.

Reference images and links

  • https://developer.android.com/jetpack/compose/text#downloadable-fonts
  • https://www.figma.com/file/XsVzpDZSkEQANgCZLRTDDy/DroidKaigi-2022-Material-3-Design-Kit?node-id=51510%3A8890

NUmeroAndDev avatar Sep 06 '22 12:09 NUmeroAndDev

I want to try this issue 🙋🏻‍♀️

risako070310 avatar Sep 06 '22 12:09 risako070310

Thanks! Assigned!🙏

takahirom avatar Sep 06 '22 12:09 takahirom

@takahirom I think this issue is to change the montserrat font in the Typography of KaigiTheme to a downloadable font, but KaigiTheme.typography is never used in this app I think so. Why is MaterialTheme.typography used in view? Which is the appropriate definition for downloadable font?

risako070310 avatar Sep 06 '22 14:09 risako070310

👀

takahirom avatar Sep 06 '22 14:09 takahirom

Thanks for inquiring! Please feel free to ask me anything. This app uses this theme throughout the app by specifying the theme here. In MaterialTheme, the theme specified in the parent Composable of Compose can be used in the child Composable. For example, MaterialTheme.typography.titleLarge is used in SessionListItem. This should use the titleLarge in the typography specified in KaigiTheme.

@Composable
fun KaigiTheme(
    // Currently, we are not supporting light theme
//    darkTheme: Boolean = isSystemInDarkTheme(),
    content: @Composable () -> Unit
) {
    MaterialTheme(
        colorScheme = DarkColorPalette,
        typography = Typography, // ←
        shapes = Shapes,
        content = content
    )
}

takahirom avatar Sep 06 '22 14:09 takahirom

Thanks to reply. I didn't know about the theme system of Compose. I'll look into it and try to implement it!!

risako070310 avatar Sep 06 '22 14:09 risako070310

@risako070310 Are you OK? How's it going?

takahirom avatar Sep 17 '22 08:09 takahirom

@takahirom I still try it now, but I didn't have much time to apply. I push my commitment until tomorrow :(

risako070310 avatar Sep 17 '22 09:09 risako070310

We can unassign you whenenever you want to give up. 👍 Please let us know if you want to.

takahirom avatar Sep 17 '22 10:09 takahirom

@takahirom I'm very sorry for the delay. I created the pull request #621 , could you please confirm this for me?

risako070310 avatar Sep 19 '22 16:09 risako070310