conference-app-2022 icon indicating copy to clipboard operation
conference-app-2022 copied to clipboard

create sponsors list screen without design

Open cOnigashima opened this issue 2 years ago • 7 comments

Idea Description create sponsors list screen without design

issue devided apply design

Reference images and links coming soon

cOnigashima avatar Sep 05 '22 03:09 cOnigashima

🙋‍♂️

ho2ri2s avatar Sep 05 '22 14:09 ho2ri2s

Thanks! Assigned 👍

tomoya0x00 avatar Sep 05 '22 14:09 tomoya0x00

May I ask a question? Do you mean implementing UI logic such as ViewModel other than UI in Compose?

ho2ri2s avatar Sep 05 '22 14:09 ho2ri2s

Thanks as always.😂 Assigned

takahirom avatar Sep 05 '22 14:09 takahirom

👀

takahirom avatar Sep 05 '22 14:09 takahirom

Sorry, I didn't see the tag of the issue. This issue will be needed to adjust for some reasons. So this issue doesn't have the welcome contribute tag. But I think we can communicate because we are colleagues. Do you want to do it?😅

takahirom avatar Sep 05 '22 14:09 takahirom

I mistakenly thought it had a welcome-contribute tag 🙇 I don't know what the problem is, but I would like to try!

ho2ri2s avatar Sep 05 '22 14:09 ho2ri2s

I'm just trying this Issue, and let me ask you a question 🙇 What is the scope of what I need to create in this Issue?

  1. create feature-sponsor module
  2. definite navigation
  3. think design myself and create screen with Compose(I think this is out of scope.)
  4. add ViewModel, Repository, and so on with logic for display in Screen
  5. fetch sponsors from specific endpoint and map to model from response model.
  6. testing

Is the scope of this Issue all except 3? (Some may not be listed.) If so, is there API documentation on what kind of Response is returned? 👀

ho2ri2s avatar Sep 10 '22 15:09 ho2ri2s

@ho2ri2s Thank you for creating your breakdown of the issue. Currently, we are creating the API. (by @RyuNen344 )

I think the response will be like this.

[
  {
    "id": "xxxxx"
    "sponsor_name": "DroidKaigi",
    "sponsor_logo": "https://hoge.png/",
    "plan": "GOLD",
    "link": "https://company.com/"
  },
...
]

Is the scope of this Issue all except 3?

Yes, but it doesn't need to make a perfect screen. I think we can improve it.

takahirom avatar Sep 11 '22 05:09 takahirom

If you have any questions let me know 🙏

takahirom avatar Sep 11 '22 08:09 takahirom

I will try to implementation by dividing PR. Thank you for your answer 🚀

ho2ri2s avatar Sep 11 '22 09:09 ho2ri2s

@ho2ri2s

sorry for late 😢

you can check it at https://ssot-api-staging.an.r.appspot.com/events/droidkaigi2022/sponsor

"status": "OK", 
"sponsor": [
  {
    "sponsorName": "DroidKaigi",
    "sponsorLogo": "https://hoge.png/",
    "plan": "GOLD", // PLATINUM, GOLD, SUPPORTER
    "link": "https://company.com/"
  },
]

If you have any questions let me know 🙏

RyuNen344 avatar Sep 11 '22 19:09 RyuNen344