conference-app-2022 icon indicating copy to clipboard operation
conference-app-2022 copied to clipboard

apply notification screen design

Open cOnigashima opened this issue 2 years ago β€’ 1 comments

Idea Description apply notification screen design

Reference images and links coming soon

cOnigashima avatar Sep 05 '22 03:09 cOnigashima

Will the design of the announcement screen be released?

l2hyunwoo avatar Sep 07 '22 01:09 l2hyunwoo

@l2hyunwoo I believe so 🎨

takahirom avatar Sep 11 '22 09:09 takahirom

The design is added! image

https://www.figma.com/file/NcSMs6dMsD88d4wOY0g3rK/DroidKaigi-2022-Conference-App?node-id=1977%3A10268

takahirom avatar Sep 19 '22 02:09 takahirom

There is a Screen root composable. But there isn't ViewModel and repository. So we should implement it. https://github.com/DroidKaigi/conference-app-2022/blob/main/feature/announcement/src/main/java/io/github/droidkaigi/confsched2022/feature/announcement/Announcement.kt

takahirom avatar Sep 19 '22 23:09 takahirom

This is the API and sample response.

https://ssot-api-staging.an.r.appspot.com/announcements/japanese

{
  "status": "string",
  "announcements": [
    {
      "id": "497f6eca-6276-4993-bfeb-53cbbbba6f08",
      "title": "string",
      "content": "string",
      "type": "ALERT",
      "publishedAt": "string",
      "deletedAt": "string",
      "language": "japanese"
    }
  ]
}

takahirom avatar Sep 19 '22 23:09 takahirom

You can refer to other screens' implementations. https://github.com/DroidKaigi/conference-app-2022/pull/331

takahirom avatar Sep 20 '22 00:09 takahirom

I would like to start on this task.

Corvus400 avatar Sep 20 '22 00:09 Corvus400

@takahirom I have a question.πŸ™‹β€β™‚οΈ If I apply the API response and my understanding, it looks like the image. How do you expect to use deletedAt and language? γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2022-09-20 11 07

Corvus400 avatar Sep 20 '22 02:09 Corvus400

Thank you for your detailed image! I think you don't have to use it. The fields are for the server side. You can access by language, so there it is. But I think we don't have to use it. And if there is deleteAt field, Please filter it in API or repository it is not for the client. https://ssot-api-staging.an.r.appspot.com/announcements/japanese https://ssot-api-staging.an.r.appspot.com/announcements/english

@RyuNen344 Is this correct?

takahirom avatar Sep 20 '22 02:09 takahirom

@takahirom @Corvus400

sorry for late πŸ™ announcement end points returns json like thisπŸ‘‡

{
  "status": "string",
  "announcements": [
    {
      "id": "497f6eca-6276-4993-bfeb-53cbbbba6f08",
      "title": "string",
      "content": "string",
      "type": "ALERT", //ALERT, NOTIFICATION, FEEDBACK
      "publishedAt": "string", //ISO-8601-datetime
      "language": "japanese"
    }
  ]
}

so, client doen't need to filter announcement by deletedAt

RyuNen344 avatar Sep 20 '22 06:09 RyuNen344

@takahirom Just to confirm, there is no need to store data in the DB, right? I assume the same is true for contributors and sponsors since they are not stored in the DB.

Corvus400 avatar Sep 20 '22 07:09 Corvus400

@Corvus400 I think there is no need too!

takahirom avatar Sep 21 '22 00:09 takahirom