conference-app-2019 icon indicating copy to clipboard operation
conference-app-2019 copied to clipboard

[WIP] Introduce Arrow Fx

Open takahirom opened this issue 6 years ago • 4 comments

Overview (Required)

  • It is still not working 😭. Probably because It is not released yet.
 E/AndroidRuntime: FATAL EXCEPTION: main
    Process: io.github.droidkaigi.confsched2019.debug, PID: 14255
    kotlin.UninitializedPropertyAccessException: lateinit property retVal has not been initialized
        at arrow.typeclasses.suspended.BlockingContinuation.getRetVal(MonadSyntax.kt:24)
        at arrow.typeclasses.suspended.MonadSyntax$DefaultImpls.effect(MonadSyntax.kt:12)
        at arrow.typeclasses.MonadContinuation.effect(MonadContinuations.kt:16)
        at io.github.droidkaigi.confsched2019.session.ui.actioncreator.SessionContentsActionCreator$toggleFavorite$1.invokeSuspend(SessionContentsActionCreator.kt:71)
        at io.github.droidkaigi.confsched2019.session.ui.actioncreator.SessionContentsActionCreator$toggleFavorite$1.invoke(Unknown Source:10)
        at arrow.typeclasses.Monad$fx$wrapReturn$1.invokeSuspend(Monad.kt:80)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:32)
        at kotlin.coroutines.ContinuationKt.startCoroutine(Continuation.kt:128)
        at arrow.typeclasses.Monad$DefaultImpls.fx(Monad.kt:81)
        at arrow.core.extensions.TryMonad$DefaultImpls.fx(Unknown Source:8)
        at arrow.core.extensions.try.monad.TryMonadKt$monad$1.fx(TryMonad.kt:195)
        at arrow.core.extensions.try.monad.TryMonadKt.fx(TryMonad.kt:178)
        at io.github.droidkaigi.confsched2019.session.ui.actioncreator.SessionContentsActionCreator.toggleFavorite(SessionContentsActionCreator.kt:70)
        at io.github.droidkaigi.confsched2019.session.ui.item.SpeechSessionItem$bind$$inlined$with$lambda$2.onClick(SpeechSessionItem.kt:80)
        at android.view.View.performClick(View.java:6294)
        at android.view.View$PerformClick.run(View.java:24770)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

takahirom avatar Feb 09 '19 09:02 takahirom

Try it via https://deploygate.com/distributions/839c04a0bac8f01c8b99f859b728244497ec7e31

jmatsu-bot avatar Feb 09 '19 09:02 jmatsu-bot

Currently, the coroutines are not canceled when coroutineContext is canceled. 😭

takahirom avatar Feb 10 '19 08:02 takahirom

Apk comparision results

Property Summary
New File Size 8496751 Bytes. (8.1 MB)
File Size Change +36259 Bytes. (+35.41 KB)
Download Size Change +34935 Bytes. (+34.12 KB)
New Method Reference Count 63263
Method Reference Count Change 554
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by :no_entry_sign: Danger

jmatsu-bot avatar Feb 10 '19 08:02 jmatsu-bot

Asserted successfully. :100:

Generated by :no_entry_sign: Danger

jmatsu-bot avatar Feb 10 '19 08:02 jmatsu-bot