conference-app-2019 icon indicating copy to clipboard operation
conference-app-2019 copied to clipboard

Published 20 hours ago • verified publisher icon DroidKaigi

Add share setting

Open takahirom opened this issue 6 years ago • 7 comments

Kind (Required)

  • Proposal / Discussion

Overview (Required)

  • Setting image is like this

Share Session Option

  • [x] Session Title
  • [x] Session URL(required?)
  • [x] Event hashtag ( #droidkaigi )
  • [x] Room Hashtag ( One of hallA, hallB, room1 ,..., room7 )

This helps share to twitter.

<session title> <session url> <hash tag>...

Full checked tweet(shared text) is below.

マルチモジュールなプロジェクトでテストはどう変わる？ https://droidkaigi.jp/2019/timetable/70713 #droidkaigi #hallA

How to do this?

I think we can do it in this step.

You can use settings fragment.

  • https://github.com/DroidKaigi/conference-app-2019/blob/master/feature/settings/src/main/java/io/github/droidkaigi/confsched2019/settings/ui/SettingsFragment.kt#L7

You can observe preference change. https://stackoverflow.com/a/38599470/4339442

Please create PreferenceActionCreator and PreferenceStore (singleton).

Please use PreferenceStore's field in SessionDetailFragment.

Links

  • Thank you for suggestion @amay077 https://github.com/DroidKaigi/conference-app-2019/issues/474#issuecomment-454298879

takahirom avatar Jan 20 '19 17:01 takahirom

I wanna try it.

karyu5b-yuki avatar Jan 22 '19 07:01 karyu5b-yuki

@karyu5b-yuki Thank you for your response! I Assigned you 💪

mhidaka avatar Jan 22 '19 07:01 mhidaka

@karyu5b-yuki How's your progress on this? Can we help with anything? 😄

takahirom avatar Jan 30 '19 10:01 takahirom

Thank you for asking. I'm working on it. When is the deadline?

karyu5b-yuki avatar Jan 31 '19 03:01 karyu5b-yuki

Version 1.0 deadline is today. 1.1 deadline is not desided. but before DroidKaigi

takahirom avatar Jan 31 '19 03:01 takahirom

I'm really sorry not replying long time. I tried, but I couldn't finish this task because of my inadequacy. Again, I'm really sorry.

karyu5b-yuki avatar Feb 07 '19 00:02 karyu5b-yuki

@takahirom I'm very sorry for the late submission.

I want to make it merge, but some problem occurred after PR. Could you check whether there are some problems in CI?

karyu5b-yuki avatar Apr 22 '19 08:04 karyu5b-yuki