conference-app-2019 icon indicating copy to clipboard operation
conference-app-2019 copied to clipboard

Add EqualableContentsProvider for SearchFragment

Open takahirom opened this issue 6 years ago • 9 comments

Kind (Required)

  • Other

Overview (Required)

  • When changing the query, it is animated.

groupie

Links

-https://qiita.com/takahirom/items/4125d7c871fad534d3c2#%E5%A4%89%E6%9B%B4%E3%82%A2%E3%83%8B%E3%83%A1%E3%83%BC%E3%82%B7%E3%83%A7%E3%83%B3%E5%95%8F%E9%A1%8C-equals--hashcode%E3%82%92%E7%84%A1%E7%90%86%E3%81%AA%E3%81%8F%E5%AE%9F%E8%A3%85%E3%81%99%E3%82%8B

takahirom avatar Jan 20 '19 04:01 takahirom

I may take some time, but can I try?

from-unknown avatar Jan 20 '19 13:01 from-unknown

Yes, of course. Thank you so much. 🥇

jmatsu avatar Jan 20 '19 14:01 jmatsu

current status: I finished implementing EqualableContentsProvider and blinking was stopped, but text highlighting was also stopped. I am looking for a way to solve it.

from-unknown avatar Jan 27 '19 03:01 from-unknown

Probably you should add query to equalableContents when if contains query word for enabling text highlighting. like this.

if(containsQuery) { query } else { null }

takahirom avatar Jan 27 '19 03:01 takahirom

Thank you for advice. I'll try it.

from-unknown avatar Jan 27 '19 04:01 from-unknown

Sorry for late! Because I have to do the other task, I will finish up this weekend.

from-unknown avatar Jan 30 '19 04:01 from-unknown

From my understanding, to update text highlighting, bind function must be called. So I will implement code like when query changed and need to update text highlight, newItem and oldItem are different.

from-unknown avatar Feb 03 '19 06:02 from-unknown

I would like to use EqualableContentsProvider for other items 🙏 I'm looking forward to your PR. 🙇

takahirom avatar Feb 03 '19 06:02 takahirom

Oops, I understand. I will finish ASAP.

from-unknown avatar Feb 03 '19 07:02 from-unknown