conference-app-2019 icon indicating copy to clipboard operation
conference-app-2019 copied to clipboard

Published 20 hours ago • verified publisher icon DroidKaigi

Dynamic feature module

Open takahirom opened this issue 6 years ago • 6 comments

Overview (Required)

  • I think this is very difficult. Can we do it? 🤔

takahirom avatar Jan 06 '19 12:01 takahirom

To test this feature, we need to distribute via PlayStore. So those who do not have permission to upload cannot take this. 😇

jmatsu avatar Jan 08 '19 05:01 jmatsu

Can we use dist:onDemand="false" for testing? https://medium.com/@star_zero/android-dynamic-feature-module-%E3%83%A1%E3%83%A2-73bd1216f45a

takahirom avatar Jan 08 '19 05:01 takahirom

Oh, I didn't know that. 👀So is it also possible for external contributors?

jmatsu avatar Jan 08 '19 05:01 jmatsu

I think we also need to decide what feature to distribute as dynamic feature. currently I can't think of one that is not needed on first launch 🤔

panpanini avatar Jan 08 '19 05:01 panpanini

If we do not have such modules, then can we use staffs page as a playground of dynamic feature? 🤔

jmatsu avatar Jan 08 '19 05:01 jmatsu

すいません、日本語で。

Dynamic Feature Moduleはfeatureモジュールの依存が今の作りと逆になります。

例えば、現状は:feature:aboutがfrontend:androidから参照されてますが、Dynamic Feature Moduleにするには逆にfrontend:androidが:feature:aboutから参照される形になります。

参考

  • https://github.com/nickbutcher/plaid/blob/master/app/build.gradle#L69
  • https://github.com/nickbutcher/plaid/blob/master/about/build.gradle#L50

STAR-ZERO avatar Jan 10 '19 03:01 STAR-ZERO