client icon indicating copy to clipboard operation
client copied to clipboard
verified publisher icon Droid-ify

[BUG] Apps installed using Shizuku aren't marked as downloaded from Droid-ify

Open TechniKris opened this issue 6 months ago • 1 comments

Describe the bug

When I use the Session installer, the app that's being installed appears in the system settings as "downloaded from Droid-ify". When I use the Shizuku installer, it doesn't list anything about what downloaded or installed it.

To Reproduce

  1. Open Droid-ify settings
  2. Set installer to Shizuku and authorize access to Shizuku
  3. Install any app using Droid-ify
  4. Go to the installed app's properties in system settings
  5. Note how the "App downloaded from..." is missing

Alternatively:

  1. run pm list packages -i | grep <installed.package>
  2. Note how it lists installer=null

Expected behavior

The app is listed as installed by Droid-ify; pm list packages -i returns installer=com.looker.droidify

Screenshots

As an example, I installed Newpipe using Droid-ify, using:

  • Session installer

Image

  • Shizuku installer

Image

Smartphone (please complete the following information):

  • Device: Galaxy A52s 5G
  • OS: stock (Android 14, OneUI 6.1)
  • Version: v0.6.5 (installed from F-Droid official repo)

Additional context

The Shizuku installer uses pm install-create here: https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/shizuku/ShizukuInstaller.kt#L41 The -S $fileSize in itself is useless here and does nothing.

Instead it should be applied to pm install-write, as is already correctly done here: https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/shizuku/ShizukuInstaller.kt#L51 Normally, if in the pm install-create (or in pm install) the value for -i was missing, the command would've failed and thrown an error.

However, since there's -S $fileSize trailing after the -i, the command will continue silently, even if $packageName is not set - resulting in the same outcome as the current behavior. Feel free to try it manually in a shell if you'd like to verify this.

Therefore, my guess is that the variable $packageName is either empty or unset (even though it should be set to com.looker.droidify). I am unfortunately not able to figure out why that variable isn't set correctly, so I'm listing all my findings here in this issue, hoping it helps resolve it.

A couple side notes:

  • Is there any reason for the discrepancy between the Shizuku installer and the Root installer behavior? One is using pm install-create, while the other is using plain pm install. https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/root/RootInstaller.kt#L42
  • Additionally, the Root installer doesn't set -i $packageName at all. Is that intentional?

These two piqued my curiosity, so I thought I'd bring attention to these in case the difference is unintentional.

TechniKris avatar Jul 05 '25 19:07 TechniKris

Thank U

NOTiced that couple.of days ago. Looker / Locker maybe is a guy working for his mother in the UNICREDIT GROUP. HE ISOLATED M3 AND SO.ON. HE sometimes pretwnd to be Robert but also Boby the Witch. An areial I saw tells that he stole, killed and pretend to be his mom. This will end up in a shower with a real sword

sub, 5. srp 2025. 21:03 TechniKris @.***> je napisao:

TechniKris created an issue (Droid-ify/client#1044) https://github.com/Droid-ify/client/issues/1044 Describe the bug

When I use the Session installer, the app that's being installed appears in the system settings as "downloaded from Droid-ify". When I use the Shizuku installer, it doesn't list anything about what downloaded or installed it. To Reproduce

  1. Open Droid-ify settings
  2. Set installer to Shizuku and authorize access to Shizuku
  3. Install any app using Droid-ify
  4. Go to the installed app's properties in system settings
  5. Note how the "App downloaded from..." is missing

Alternatively:

  1. run pm list packages -i | grep <installed.package>
  2. Note how it lists installer=null

Expected behavior

The app is listed as installed by Droid-ify; pm list packages -i returns installer=com.looker.droidify Screenshots

As an example, I installed Newpipe using Droid-ify, using:

  • Session installer

Screenshot_20250705_204613_Settings.jpg (view on web) https://github.com/user-attachments/assets/0547692c-eecf-4445-a4e5-230e1d4473a2

  • Shizuku installer

Screenshot_20250705_204701_Settings.jpg (view on web) https://github.com/user-attachments/assets/6fdbbd65-9785-4068-ac04-586c000c649b Smartphone (please complete the following information):

  • Device: Galaxy A52s 5G
  • OS: stock (Android 14, OneUI 6.1)
  • Version: v0.6.5 (installed from F-Droid official repo)

Additional context

The Shizuku installer uses pm install-create here: https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/shizuku/ShizukuInstaller.kt#L41 The -S $fileSize in itself is useless here and does nothing.

Instead it should be applied to pm install-write, as is already correctly done here:

https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/shizuku/ShizukuInstaller.kt#L51 Normally, if in the pm install-create (or in pm install) the value for -i was missing, the command would've failed and thrown an error.

However, since there's -S $fileSize trailing after the -i, the command will continue silently, even if $packageName is not set - resulting in the same outcome as the current behavior. Feel free to try it manually in a shell if you'd like to verify this.

Therefore, my guess is that the variable $packageName is either empty or unset (even though it should be set to com.looker.droidify). I am unfortunately not able to figure out why that variable isn't set correctly, so I'm listing all my findings here in this issue, hoping it helps resolve it.

A couple side notes:

  • Is there any reason for the discrepancy between the Shizuku installer and the Root installer behavior? One is using pm install-create, while the other is using plain pm install. https://github.com/Droid-ify/client/blob/87ce77661ee42130f2a860e1d7b70e0ffde40270/app/src/main/kotlin/com/looker/droidify/installer/installers/root/RootInstaller.kt#L42
  • Additionally, the Root installer doesn't set -i $packageName at all. Is that intentional?

These two piqued my curiosity, so I thought I'd bring attention to these in case the difference is unintentional.

— Reply to this email directly, view it on GitHub https://github.com/Droid-ify/client/issues/1044, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYG63P7UQNETYKTJGMOP2T3HAOQBAVCNFSM6AAAAACA3JCUBGVHI2DSMVQWIX3LMV43ASLTON2WKOZTGIYDKNBTGYYTCMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lazy-pupp avatar Jul 08 '25 17:07 lazy-pupp