simple-tab-groups icon indicating copy to clipboard operation
simple-tab-groups copied to clipboard

Notification shown when moving tab from context menu even if turned off

Open LinAGKar opened this issue 1 year ago • 6 comments

Describe the bug When notifications for moving tabs to a group is turned off, it still shows notifications when moving tabs from the tab context menu.

To Reproduce Steps to reproduce the behavior:

  1. Disable notification on move for a tab group
  2. Move a tab to the group with the tab context menu

Expected behavior It should not show a notification

Desktop (please complete the following information):

  • OS and version: OpenSUSE Leap 15.5 Plasma
  • Firefox version: 102.11.0esr
  • Simple Tab Groups version: 5.2

LinAGKar avatar Jul 07 '23 09:07 LinAGKar

Confirming this. This setting used to work a few versions ago

Flavelius avatar Aug 22 '23 15:08 Flavelius

Same here. MacOS Ventura. Firefox 117.0 STG 5.2.

Tab groups which already had the setting of are not generating notifications, but I created a new group just now and even though I turned this off, I'm getting notifications.

Would actually prefer #1067 (I'm not sure who is the intended audience for these notifications, but not me).

retorquere avatar Sep 21 '23 18:09 retorquere

Please fix this. It's basically forcing me to disable notifications for Firefox altogether, which is not what I want.

Imsvale avatar Nov 10 '23 07:11 Imsvale

Are we sure this is still a thing? Works as expected for me.

STG Version: 5.2 Librewolf Version: 125.0.3-1 Fedora/Linux Version: Linux panda-gnome 6.8.8-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Apr 27 17:42:13 UTC 2024 x86_64 GNU/Linux

zetaomegagon avatar May 09 '24 20:05 zetaomegagon

FYI, I would also prefer #1067 be implemented, but as a workaround, I backed up my tab groups to JSON then did a search and replace:

"showNotificationAfterMovingTabIntoThisGroup": true --> "showNotificationAfterMovingTabIntoThisGroup": false

Then imported the backup.

zetaomegagon avatar May 09 '24 20:05 zetaomegagon

Are we sure this is still a thing? Works as expected for me.

STG Version: 5.2 Librewolf Version: 125.0.3-1 Fedora/Linux Version: Linux panda-gnome 6.8.8-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Apr 27 17:42:13 UTC 2024 x86_64 GNU/Linux

Appears to work correctly now for me too. Didn't do any tab moving after I got my initials set up, so I guess it stopped bothering me.

  • STG 5.2
  • Firefox 125.0.3
  • Windows 11 (22631.3447)

Which is funny because STG version hasn't changed. Maybe a Firefox update is what broke it, and then it got un-broken. shrug

Imsvale avatar May 09 '24 21:05 Imsvale