simple-tab-groups icon indicating copy to clipboard operation
simple-tab-groups copied to clipboard

STG crashes when site display popup and closes it directly

Open jpyllman opened this issue 2 years ago • 6 comments

I have some sites that do a popup and then closes it directly. This makes STG stop working. I have tried to turn of all options in STG regarding popups but nothing helps.

So after I go to the site I have to disable and re-enable STG for it to work. The current tabs stay the same. And the re-enable works fine.

This have been a problem for me with multiple version of both firefox and STG. But currently I am using the one below.

Desktop (please complete the following information):

  • OS and version: Windows 10
  • Firefox version: 112
  • Simple Tab Groups version: 5.1

jpyllman avatar Apr 24 '23 10:04 jpyllman

I can't understand what you're talking about at all. Maybe you can record a GIF, and give me an example of such a site where STG breaks down? Thanks! https://www.cockos.com/licecap/

Drive4ik avatar Apr 27 '23 19:04 Drive4ik

I do not have any example of this out on the internet. But this is a thing that the platform used to build this site wants to test if you have popup blocking on or not. So it tries to do a popup of a window if you do not have a cookie that already show the result of the test. When I have STG active the window is popped and then gets closed directly and STG crashes.

I have done some testing. And I am not sure who actually closes the popup. I thought you had to do it yourself. But now it gets closed both when I have STG activated and not. But when I have STG active it crashes. So, does STG try to do anything to popups that a website opens??

jpyllman avatar Apr 28 '23 05:04 jpyllman

I have now recorded a gif. And it will only show a popup that quickly disappears and the STG icon get disabled. recording

jpyllman avatar Apr 30 '23 15:04 jpyllman

This happens to me sometimes when site open pop-up windows: Screenshot_2023-05-01_21-29-52 Screenshot_2023-05-01_21-20-55

mare1203 avatar May 01 '23 19:05 mare1203

I have done some more testing. I installed STG on a new install of Firefox. And I did not get the 'crash'. But after looking through what settings was different between the two installation was settings on the group about container tabs. I have that a specific container should be set in that specific group. And also, move tabs with this container into this group. If I remove the last setting it looks like I am not getting the crash any more. I will do more testing. And I really would like to have that setting.

Maybe should not include popups in this part. They are not tabs?

jpyllman avatar May 09 '23 12:05 jpyllman

I think I have a similar issue. One of my work-related sites displays a popup notification in the middle of the page at the same time as it updates the page in the background. The page refresh seems to break the add-on and I need to disable and re-enable it manually to be able to continue using it.

On a bit of testing, the logout/login-related page update seems to be the problem, not the popup notification.

CeaselessWatcher avatar Mar 20 '24 09:03 CeaselessWatcher