Andrew Levine
Andrew Levine
I have a few different POCs of this locally with `webpack@next` and various different ways of going from Babylon >> ESTree. Just looking for some medium/large sized projects to profile...
> I think I'd push for it being opt-in. Agreed. I'm still skeptical this will have any real perf benefits, but I wanted to actually profile it so we can...
Looks like this is more challenging that just passing an ESTree-compatible AST back to `webpack`. I created the [lazy-babylon-to-estree](https://github.com/DrewML/lazy-babylon-to-estree/) package to do the minimum amount of changes needed for `webpack`...
> The location ranges in the AST reference the locations in the original source content passed to the loader, not the position in the resulting code string returned from the...
cc @adifucan - any ideas?
Thanks for the report @jhruehl, and thanks for digging in @adifucan. Based on what @adifucan showed me, I believe I know the root cause and how we regressed this. ###...
For the **Fast** solution mentioned above, we can take care of the ignore in [`computeDepsForBundle.ts`](https://github.com/magento/baler/blob/f6dc98d716dd1e80d63eb47d47fd1627f9a75b3d/src/computeDepsForBundle.ts), which is the same place we exclude require built-ins. Would allow us to keep a...
@tdgroot submitted (and I merged) a PR that excluded `js-translation.json` for now (aka the "fast" fix), and we'll leave this open until we do the "thorough" solution.
Thanks for the report @jiazhengshi. Can you send me the output of running the following 3 commands on their own, from the root of the repo? ```sh ls node_modules/.bin ```...
Labeling this as a bug because that's way too much time. Believe we can address this with a mix of parallelized minifying and proper ignores.