typescript-declarations-for-ext icon indicating copy to clipboard operation
typescript-declarations-for-ext copied to clipboard

Published 20 hours ago • verified publisher icon Dretch

Add support for extjs6

Open baronfel opened this issue 8 years ago • 3 comments

A few changes to add in support for ExtJS 6. I had to add a few packages to the jsduck listing, because Sencha has done some reorganization of the sencha source code. In addition, they package differently depending on if you use the modern or classic toolkits, so I added a theme switcher. It may be nice to generate all configurations (classic/modern) for a particular version?

In addition, I got a few warnings when generating these files, mostly around how a few Ext classes could not be found in the sources I provided (Ext.Component, Ext.container.Container, and Ext.dom.Element were the biggest ones). I didn't find these sources anywhere in the downloaded zip. Maybe you have better luck?

baronfel avatar May 06 '16 16:05 baronfel

Wow, thanks for putting in the effort to add ExtJS 6 support!

I will merge it if you fix the small issues I have put comments on.

Regarding your questions, I have not used ExtJS6 so I am unfortunately not best placed to answer them intelligently. I did notice that the generated type declarations file for 6.0.1 is half the size of the one for 5.1.0, which suggests there might be stuff missing.

Dretch avatar May 06 '16 17:05 Dretch

@Dretch Thanks for the review! I'm not very confident that these are correct at all, so I'll make your fixes and see. I want to spend a bit more time trying to integrate this at my work before saying this is ok. I'm definitely not certain that I have all of the required Ext members.

baronfel avatar May 06 '16 20:05 baronfel

@baronfel

I will leave off merging this until you are happier with it, then. Thanks for addressing my comments :+1:

Dretch avatar May 07 '16 10:05 Dretch