MyTargets icon indicating copy to clipboard operation
MyTargets copied to clipboard

Assign Arrow properties

Open tzbob opened this issue 7 years ago • 5 comments

Hello, I've been using your app for ages so thanks!

Something that I think would be nice is an additional property to mark arrows. At the moment I think the only feature is arrow numbering. When testing fletchings for example it would be nice to add these in this way. All the features are already there (at the moment I just enter all arrows as either 1 or 2).

Do you have any idea what the user interface for such a feature would look like? If you have something in mind and can show me where the appropriate code is I can send a pull-request.

Cheers

tzbob avatar Jun 13 '17 09:06 tzbob

Hi, sounds interesting! Even though you can encode the information as arrow numbers, I would not use them to store such tags. ATM every Shot entry in the database has a column for the arrow's number it was shot with. <brainstorming> Database Since you would likely want to be able to add multiple tags per shot two additional tables would be needed. One to store the Tags (tag-id, tag-name) and one (auto-generated by dbFlow) to store the mapping from Shots to Tags.

User interface To select the tags I would probably add a ChipGroup to the arrow number picker. Creation of new possible tags could go into the settings screen. To actually make use of the tags the available tags should be selectable from the filter menu in the statistics. </brainstorming>

What do you think?

Unfortunately, I'm currently busy with my master's thesis...

Cheers

DreierF avatar Jun 13 '17 13:06 DreierF

This sounds good. I forgot exactly where but there is a page that shows individual 'arrow score' which when clicked shows an arrow's group. I suppose this would be good to add as well.

Since (so far) I'm probably the only person who wants this feature I suggest I'll try and implement it. I'm also short on time for the moment but I'll work on it slowly.

Is there a gitter channel or some other equivalent on which I could ask questions in the case I have some issues in starting up? I wouldn't want to spam a github issue as if it were a chat :).

tzbob avatar Jun 15 '17 08:06 tzbob

Perfect 👍 Since I'm basically the only one who works on the project there was no need yet to create a gitter channel, but I'm glad to help you if you have any questions. If you send me your Telegram (preferred) or WhatsApp contact details to [email protected], I'll add you there 😉

DreierF avatar Jun 15 '17 08:06 DreierF

Since two other users have contacted me with quite similar use cases I wanted to document those here as well as expand the general idea behind the tags:

  • Experiment with different bow settings
  • Decide between two different types of releases

In addition to providing the possibility to select a tag for each shot, it should also be possible to set a tag for a whole end, round or training. (Integrate into the comment dialog available since 3.0.0)

DreierF avatar Jan 18 '18 10:01 DreierF

I haven't found time to work on this issue, I had an old local branch somewhat working by adding a new property to shots.

I think it would be very valuable to be able to add tags for all of them as long as the relevant statistics can also be filtered on those tags afterwards such as comparing groups, etc.

tzbob avatar Jan 18 '18 10:01 tzbob