git-wiki-theme icon indicating copy to clipboard operation
git-wiki-theme copied to clipboard

Improve Sidebar Functionality

Open trillium opened this issue 2 years ago • 1 comments


name: Feature request about: Improve sidebar functionality title: '' labels: '' assignees: ''


Improve Sidebar Functionality

Is your feature request related to a problem? Please describe.

Escape key, clicking outside of the sidebar, and clicking on internal page navigation links within sidebar do not close sidebar.

Describe the solution you'd like

  • Close sidebar when escape key is pressed
  • Close sidebar when click is registered outside of sidebar

Describe alternatives you've considered

I've made a functional update for Talon Wiki with the behavior listed above here, but it's written in javascript and changes a few things such as element IDs that you may choose to do differently.

Additional context

Thanks for building a great tool, I'd like to give back a little if able :)

trillium avatar Oct 03 '22 17:10 trillium

Hi! Sorry for the huge delay

Thanks for using the git-wiki. Looking at your changes in Talon Wiki I think they are quite safe to be applied here as well, if you want you can open a PR and I can test and approve them

Yehonal avatar Apr 23 '23 14:04 Yehonal