modmailbot icon indicating copy to clipboard operation
modmailbot copied to clipboard

Problematic UX: close with typo'd args closes the thread immediately

Open didinele opened this issue 2 years ago • 1 comments

Attempted to !close cancel but misspelled the word cancel, as a result, the thread was immediately closed.

This is particularly poor UX, and I feel like arguments given to close should be properly parsed, and, if invalid, the command should error out.

didinele avatar Oct 19 '21 09:10 didinele

This problem arises because close allows for a variety of options and only uses direct checks for those options. Changing to the in-built command argument system would likely also only complicate matters and not catch invalid arguments because those are simply ignored. Additionally, some users put their close reasons behind the !close command and retroactively changing that behavior to error out seems impractical. I would recommend using just the initial letters for short and cancel, so !close c for the time being as it's faster and a lot less error prone. (Yes, the fact that initials also work for cancel should be in the docs)

DarkView avatar Oct 22 '21 11:10 DarkView