bemaniutils
bemaniutils copied to clipboard
DragonMinded
Iidx hv and bistro
Missing traffic tests. I can't think of any obvious issues with the pull request in its current state though so I'm submitting as is for now. I'll do traffic tests in a bit (Already recorded packet logs for them I just need to sit down and do the rest). If you have any design objections feel free to bring them up though! :) As an aside, it might be advisable to update the bemapi spec to account for the new iidx charts...
No online arena, but local arena should work by default. I personally don't find enough of a use for online lobby to bother implementing it for any game... With games like iidx, I have to wonder if it might be more advisable to make a separate project just for scraping the musicdbs with charts, and then just having some json blobs stored in this repository with which to seed the database. Because of how much manual mangling has to be done, I just have to wonder if using the chart parser to create a unique id for each chart and using that to determine the server id would be better than what we currently do. For example, with the modern to legacy stuff, I'm honestly not 100% certain the list is completely accurate, and checking for compete accuracy would be a pretty painstaking process if done manually...
Having a repo that is good at one thing: scraping metadata from ANY game ANYWHERE would actually be a pretty useful thing to have. If its structured right, bemaniutils can just depend on it and have a simple wrapper or something. I have, however, shied away from any scraped or copyright data in this repo, hence why you need to seed your installation from another active one or from your own sourced game files. Wouldn't be against somebody taking the read code, putting it in its own repo, cleaning it up and also checking in per-game blobs. I just won't be the one to do that ;)
I've been running this branch for a little while. It seems okay for now, but I've spotted few issues within the code. Suggestions above are what I've found.
Also, bemani/frontend/static/iidx-options.js file needs to be updated with options for 27 and 28.
