Discord-Scraper icon indicating copy to clipboard operation
Discord-Scraper copied to clipboard

Not downloading videos

Open emerysteele opened this issue 4 years ago • 2 comments

Tried out the experimental version as the master appears to have issues going back farther than 5-6 weeks for me.

But experimental is not downloading videos.

emerysteele avatar Apr 06 '20 05:04 emerysteele

Yes, this is likely due to the issues with embedded content. Something that's been plaguing this script for well over a year now.

I do recommend people try out the experimental version of the script as it addresses multiple problems with the master branch, but it's not all-encompassing.

So far the biggest issue I'm facing is the fact that the script grabs the whole JSON data from the server as it should, and yet less than half of the data in the JSON file is ending up being grabbed.

What that means is the script is succeeding in grabbing all of the JSON data that it's supposed to, but there are issues with grabbing the contents linked within the JSON data.

I do attempt to grab the data that Discord proxies as seen here: https://github.com/Dracovian/Discord-Scraper/blob/experimental/Discord/Discord.py#L183

I should rewrite the script again, this time around I should focus more on verbosity and error handling.

Dracovian avatar Apr 06 '20 05:04 Dracovian

I have yet to see if the experimental_requests branch is able to grab video contents, but I am hedging a bit on 3rd party modules because it definitely seems as if I have my work cut out for me whenever it comes to maintaining my custom modules.

I also made the same recommendation in the previous conversation, the history of my response was due to not reading this conversation beforehand. So disregard my edit where I brought up the experimental branch since you already found issues with it as well.

Soon I'll merge the experimental_requests and experimental branches when everything is accounted for in the experimental_requests branch. I'll be glad to not have to type out the name of that branch when the time comes.

Dracovian avatar Apr 23 '20 10:04 Dracovian