SuiteSparse icon indicating copy to clipboard operation
SuiteSparse copied to clipboard

Fix a find_package(UMFPACK) bug in ParU/CMakeLists.txt

Open valgur opened this issue 1 year ago • 2 comments

External UMFPACK is currently not being found due to a small bug in ParU/CMakeLists.txt.

valgur avatar Apr 01 '24 07:04 valgur

Oof. That's probably a copy-paste error ~~that wasn't caught by CI because CAMD_FOUND happened to be set after find_package(CHOLMOD)~~.

Your change looks good to me. Thank you for your contribution. 👍

Edit: Strike that previous remark. The CI didn't catch it because it is linking to the CHOLMOD libraries in the common build or source tree. 🤦 Your change still looks good though. 👍

mmuetzel avatar Apr 03 '24 08:04 mmuetzel

Thanks for the catch.

I realize this is a very minor change, but my organization requires that any contributor signs a contributor agreement (a copy is at the top-level in SuiteSparse). Can you sign it and send it to me?

DrTimothyAldenDavis avatar Apr 17 '24 20:04 DrTimothyAldenDavis

This change fixes a bug in the current CMake rules. I'm assuming that @valgur didn't respond in more than 6 weeks. With that in mind, what should be done with this change?

mmuetzel avatar May 17 '24 15:05 mmuetzel

I emailed my signed contributor license now. Apologies for the delay.

valgur avatar May 17 '24 19:05 valgur