Telegram icon indicating copy to clipboard operation
Telegram copied to clipboard

Reducing the function calls by simply creating a variable

Open aravindkanna opened this issue 9 years ago • 4 comments

Here in the ActionBarMenu.java the function getChildCount() is being called in the for loop in all iterations. Instead creating a variable can make this simple I guess.

aravindkanna avatar Jun 03 '16 14:06 aravindkanna

@aravindkanna good job! But you don't forget one of base rule: "One branch -> one feature". Therefore, you don't need to change gradle dependencies at this commit, i think.

abcdeiko avatar Jul 06 '16 03:07 abcdeiko

@abcdeiko , Thank you. so what should I do now? Create a new branch or change the current branch? Actually that was happened when I tried to merge. The fault was to commit before pulling the current remote.

aravindkanna avatar Jul 06 '16 04:07 aravindkanna

@aravindkanna you don't need any action now, because DrKLO already merged your commit. To prevent merge conflicts you can fetch last changes from master branch and rebase it on your working branch before create a new pull request.

abcdeiko avatar Jul 06 '16 06:07 abcdeiko

Thank you.

similato avatar Aug 25 '16 17:08 similato