PlayBooks icon indicating copy to clipboard operation
PlayBooks copied to clipboard

trigger product update modal

Open rishsanyal opened this issue 1 year ago • 3 comments

There's a small issue for first-time users where every page will show the Product Update Modal to the customer.

Playbooks currently depends on setting the last-login time cookie to know if this modal should be displayed or not. There's 2 issues with this:

New customers from the same browser won't get the chance to sign up for product updates A first time customer will just face annoyances for the first time they interact with Playbooks' platform. This PR fixes that by ensuring that on registering we focus on the new customer through setting the option in the redux store and clearing the last-login time cookie on re-registering

I've added 2 videos below. The first one shows the issue and the second validates the fix.

Issue: https://github.com/user-attachments/assets/2f6c0db1-cc50-4bad-8b9c-fd38516a8887

Validated Fix:

https://github.com/user-attachments/assets/7abf09e4-aaa2-4036-aa77-f4ea7a6cbe93

rishsanyal avatar Aug 14 '24 07:08 rishsanyal

@droid-mohit @jayeshsadhwani99 Thank you for your patience and help. Created the new PR here.

Apologies for the confusion with the previous PR once again.

rishsanyal avatar Aug 14 '24 07:08 rishsanyal

@jayeshsadhwani99 can you please review this PR?

sidPhoenix17 avatar Aug 19 '24 15:08 sidPhoenix17

@rishsanyal Please update your branch from main branch. This was commented a while ago. Also, please edit the PR to be raised against integration branch. That is where all changes go before it is merged into main.

dimittal avatar Aug 20 '24 05:08 dimittal

@jayeshsadhwani99 : Thank you for catching that. I've updated the code to register the event as the user not signing up for updates now.

rishsanyal avatar Aug 23 '24 17:08 rishsanyal