semi-design icon indicating copy to clipboard operation
semi-design copied to clipboard

Chore: Disable Typography warning when user specified copyable.content

Open oddguan opened this issue 2 years ago • 4 comments

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Test Case
  • [ ] TypeScript definition update
  • [ ] Document improve
  • [ ] CI/CD improve
  • [ ] Branch sync
  • [ ] Other, please describe:

PR description

Fixes #573

Changelog

🇨🇳 Chinese

  • Fix: 修复Typography手动传入copyable.content时控制台依旧有warning

🇺🇸 English

  • Fix: Disabled warning from Typography when user specified copyable.content

Checklist

  • [x] Test or no need
  • [ ] Document or no need
  • [ ] Changelog or no need

Other

  • [ ] Skip Changelog

Additional information

oddguan avatar Mar 25 '22 08:03 oddguan

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acb9d2ff08d6dc9b5db401cbed4e99c34ea16d27:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

codesandbox-ci[bot] avatar Mar 25 '22 08:03 codesandbox-ci[bot]

Codecov Report

Merging #724 (abd44db) into release (d191df0) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           release     #724   +/-   ##
========================================
  Coverage    81.23%   81.23%           
========================================
  Files          366      366           
  Lines        20724    20726    +2     
  Branches      5305     5307    +2     
========================================
+ Hits         16835    16837    +2     
  Misses        3869     3869           
  Partials        20       20           
Impacted Files Coverage Δ
packages/semi-ui/typography/base.tsx 82.02% <100.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d191df0...abd44db. Read the comment docs.

codecov-commenter avatar Mar 25 '22 08:03 codecov-commenter

@pointhalo 打扰一下,可以麻烦看看这里workflow跑不过是什么原因吗?并没有修改DatePicker相关的逻辑,是不是有点问题

oddguan avatar Mar 31 '22 12:03 oddguan

@pointhalo 打扰一下,可以麻烦看看这里workflow跑不过是什么原因吗?并没有修改DatePicker相关的逻辑,是不是有点问题

应该是cypress e2e结果有点问题,先忽略吧。这个用例本地跑是ok的。具体原因得再看一下

pointhalo avatar Apr 01 '22 03:04 pointhalo

问题已被修复

YyumeiZhang avatar Jul 03 '23 06:07 YyumeiZhang