semi-design
semi-design copied to clipboard
perf(overflowlist): optimize collapse rendering
- [ ] I have read and followed Pull Request Guidelines of the contributing guide.
What kind of change does this PR introduce? (check at least one)
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update
- [x] Refactor
- [ ] Test Case
- [ ] TypeScript definition update
- [ ] Document improve
- [ ] CI/CD improve
- [ ] Branch sync
- [ ] Other, please describe:
PR description
TODO
- [x] item 的 margin + padding 需要纳入占宽的计算
- [x] OverflowRender结果是
ReactNode[]
的情况,需要再包一个父级元素用来计算宽度 - [ ] test(更适合用cy来测)
- [x]
collapseFrom
为end
时的情况
Fixes #
Changelog
🇨🇳 Chinese
- Fix: 修复 ...
🇺🇸 English
- Fix: fix ...
Checklist
- [ ] Test or no need
- [ ] Document or no need
- [ ] Changelog or no need
Other
- [ ] Skip Changelog
Additional information
Codecov Report
Base: 88.92% // Head: 88.92% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
d2bd13d
) compared to base (32381ad
). Patch coverage: 94.54% of modified lines in pull request are covered.
:exclamation: Current head d2bd13d differs from pull request most recent head 158a87f. Consider uploading reports for the commit 158a87f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 88.92% 88.92% -0.01%
==========================================
Files 431 431
Lines 24527 24574 +47
Branches 6131 6144 +13
==========================================
+ Hits 21811 21852 +41
- Misses 2716 2722 +6
Impacted Files | Coverage Δ | |
---|---|---|
packages/semi-foundation/table/constants.ts | 100.00% <ø> (ø) |
|
packages/semi-ui/autoComplete/index.tsx | 95.72% <ø> (ø) |
|
packages/semi-ui/datePicker/datePicker.tsx | 99.12% <ø> (ø) |
|
packages/semi-ui/dropdown/index.tsx | 84.05% <ø> (ø) |
|
packages/semi-ui/inputNumber/index.tsx | 91.46% <ø> (ø) |
|
packages/semi-ui/popover/index.tsx | 100.00% <ø> (ø) |
|
packages/semi-ui/tag/index.tsx | 96.96% <ø> (ø) |
|
...ackages/semi-foundation/overflowList/foundation.ts | 94.20% <92.59%> (-2.47%) |
:arrow_down: |
packages/semi-ui/overflowList/index.tsx | 93.93% <93.22%> (-2.26%) |
:arrow_down: |
packages/semi-foundation/overflowList/constants.ts | 100.00% <100.00%> (ø) |
|
... and 10 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 158a87f2d387128bd90dae359dae5d8ff78d7b12:
Sandbox | Source |
---|---|
pr-story | Configuration |
Semi Design: Simple Story | Configuration |
Test summary
Run details
Project | semi-design |
Status | Passed |
Commit | 541c02cb29 ℹ️ |
Started | Mar 31, 2022 2:01 PM |
Ended | Mar 31, 2022 2:05 PM |
Duration | 03:19 💡 |
OS | Linux Debian - 10.8 |
Browser | Multiple |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard