feat: modal add modalRender prop
- [x] I have read and followed Pull Request Guidelines of the contributing guide.
What kind of change does this PR introduce? (check at least one)
- [ ] Bugfix
- [x] Feature
- [ ] Code style update
- [ ] Refactor
- [ ] Test Case
- [ ] TypeScript definition update
- [ ] Document improve
- [ ] CI/CD improve
- [ ] Branch sync
- [ ] Other, please describe:
PR description
Fixes https://github.com/DouyinFE/semi-design/issues/2655
Changelog
🇨🇳 Chinese
- Feature: Modal 支持 modalRender 参数自定义渲染弹窗 #2655
🇺🇸 English
- Feature: Modal supports modalRender parameter to customize rendering #2655
Checklist
- [x] Test or no need
- [x] Document or no need
- [x] Changelog or no need
Other
- [x] Skip Changelog
Additional information
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit dd0028407923ead18297e7d957615eff730c60d7:
| Sandbox | Source |
|---|---|
| pr-story | Configuration |
本次 beta 版本更不上,提交的 feat 会在下个 beta 版本前 review, fix 相关会在下个正式版本前处理
@YyumeiZhang @pointhalo 能否抽空 review 下我的 PR?目前 CI 中的报错应该不是我的 PR 引起的,我并没有变更依赖,我该如何解决。
https://github.com/DouyinFE/semi-design/pull/2779 https://github.com/DouyinFE/semi-design/pull/2778 https://github.com/DouyinFE/semi-design/pull/2774 https://github.com/DouyinFE/semi-design/pull/2773
@YyumeiZhang @pointhalo 能否抽空 review 下我的 PR?目前 CI 中的报错应该不是我的 PR 引起的,我并没有变更依赖,我该如何解决。
#2779 #2778 #2774 #2773
CI 中的报错可能和你是非组织用户有关系,你可以不用处理。 fix 的 PR #2773, #2778 已经 review 并合入,Feat 的 PR 在下一个 beta 版本的时候做下处理
@YyumeiZhang 打扰了,能辛苦 review 下我的两个 Feat PR 嘛。 https://github.com/DouyinFE/semi-design/issues/2655 https://github.com/DouyinFE/semi-design/issues/1015
semi-design
Run #3242
Run Properties:
Passed #3242 •
974f969eba: feat: modal add modalRender prop (#2779)
| Project |
semi-design
|
| Branch Review |
release
|
| Run status |
|
| Run duration | 08m 14s |
| Commit |
|
| Committer | LonelySnowman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
13
|
|
|
0
|
|
|
286
|
| ⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |