semi-design icon indicating copy to clipboard operation
semi-design copied to clipboard

fix: fix click outside handler in webcomponent

Open changlin2569 opened this issue 1 year ago • 1 comments

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Test Case
  • [ ] TypeScript definition update
  • [ ] Document improve
  • [ ] CI/CD improve
  • [ ] Branch sync
  • [ ] Other, please describe:

PR description

Fixes # Fix the inaccurate judgment of clickOutSide in webComponent #1381

Changelog

🇨🇳 Chinese

  • Fix: 修复 clickOutSide 在 webComponent 中判断不准确的问题

🇺🇸 English

  • Fix: fix the inaccurate judgment of clickOutSide in webComponent

Checklist

  • [x] Test or no need
  • [x] Document or no need
  • [x] Changelog or no need

Other

  • [ ] Skip Changelog

Additional information

changlin2569 avatar Feb 21 '24 08:02 changlin2569

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55bd88f257e668336c41709a4104199ba4eb2ad9:

Sandbox Source
pr-story Configuration

codesandbox-ci[bot] avatar Feb 21 '24 08:02 codesandbox-ci[bot]

周末我改下

changlin2569 avatar Mar 13 '24 01:03 changlin2569

Codecov Report

Attention: Patch coverage is 83.14607% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 88.18%. Comparing base (cefdb56) to head (dd85f89). Report is 182 commits behind head on main.

:exclamation: Current head dd85f89 differs from pull request most recent head 55bd88f. Consider uploading reports for the commit 55bd88f to get more accurate results

Files Patch % Lines
packages/semi-ui/button/splitButtonGroup.tsx 0.00% 18 Missing :warning:
packages/semi-foundation/image/utils.ts 21.42% 11 Missing :warning:
packages/semi-ui/_utils/index.tsx 85.18% 4 Missing :warning:
packages/semi-ui/avatar/index.tsx 33.33% 4 Missing :warning:
packages/semi-ui/typography/base.tsx 86.66% 4 Missing :warning:
...ackages/semi-foundation/descriptions/foundation.ts 87.50% 3 Missing :warning:
packages/semi-ui/descriptions/index.tsx 88.46% 3 Missing :warning:
packages/semi-ui/image/previewInner.tsx 0.00% 3 Missing :warning:
packages/semi-ui/modal/Modal.tsx 50.00% 3 Missing :warning:
packages/semi-ui/resizeObserver/index.tsx 88.23% 2 Missing :warning:
... and 5 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
+ Coverage   87.38%   88.18%   +0.80%     
==========================================
  Files         437      440       +3     
  Lines       25685    25954     +269     
  Branches     6508     6617     +109     
==========================================
+ Hits        22445    22888     +443     
+ Misses       3240     3066     -174     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 17 '24 10:03 codecov-commenter